Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong group creation in mutate UserCreation #1762

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix: wrong group creation in mutate UserCreation #1762

merged 1 commit into from
Dec 7, 2023

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Dec 5, 2023 •
edited
Loading

follow-up #1749

There was wrong codes of handling groups in UserCreation mutation.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@fregataa fregataa added this to the 24.03 milestone Dec 5, 2023
@fregataa fregataa self-assigned this Dec 5, 2023
@github-actions github-actions bot added comp:manager Related to Manager component size:XS ~10 LoC labels Dec 5, 2023
@fregataa fregataa added urgency:5 It is imperative that action be taken right away. urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE! skip:changelog Make the action workflow to skip towncrier check and removed comp:manager Related to Manager component size:XS ~10 LoC urgency:5 It is imperative that action be taken right away. labels Dec 5, 2023
@agatha197 agatha197 self-requested a review December 7, 2023 02:28
agatha197
agatha197 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fregataa fregataa added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit 902c9f0 Dec 7, 2023
50 of 72 checks passed
@fregataa fregataa deleted the fix/user-creation-handle-groups branch December 7, 2023 02:53
@achimnol achimnol modified the milestones: 24.03, 23.09 Dec 7, 2023
fregataa added a commit that referenced this pull request Dec 13, 2023
@fregataa
fix: wrong group creation in mutate UserCreation (#1762)
c919d9b 
Backported-from: main
Backported-to: 23.09
@fregataa fregataa mentioned this pull request Jun 25, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197 agatha197 approved these changes

@achimnol achimnol Awaiting requested review from achimnol

@kyujin-cho kyujin-cho Awaiting requested review from kyujin-cho

Assignees

@fregataa fregataa

Labels
skip:changelog Make the action workflow to skip towncrier check urgency:blocker IT SHOULD BE RESOLVED BEFORE NEXT RELEASE!
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.
3 participants
@fregataa @agatha197 @achimnol