Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle user creation failure when model-store does not exists #2160

Merged
merged 6 commits into from
Jul 4, 2024

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented May 21, 2024

follow-up #1762
Cannot create a user when model-store project does not exist.
Let's fix it

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

@fregataa fregataa added the urgency:4 As soon as feasible, implementation is essential. label May 21, 2024
@fregataa fregataa added this to the 24.03 milestone May 21, 2024
@fregataa fregataa self-assigned this May 21, 2024
Copy link

graphite-app bot commented May 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added comp:manager Related to Manager component size:S 10~30 LoC labels May 21, 2024
@fregataa fregataa added urgency:5 It is imperative that action be taken right away. and removed urgency:4 As soon as feasible, implementation is essential. labels May 23, 2024
@fregataa fregataa changed the title fix: Handle user creation when model-store not exists fix: Handle user creation failure when model-store does not exists Jun 20, 2024
@fregataa fregataa force-pushed the fix/create-user-without-modelstore branch from 38df28d to 6f411ef Compare July 4, 2024 08:27
@fregataa fregataa merged commit 4739d81 into main Jul 4, 2024
29 checks passed
@fregataa fregataa deleted the fix/create-user-without-modelstore branch July 4, 2024 08:33
lablup-octodog pushed a commit that referenced this pull request Jul 4, 2024
…2160)

Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2160
lablup-octodog added a commit that referenced this pull request Jul 4, 2024
…2160) (#2381)

Co-authored-by: Sanghun Lee <[email protected]>
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:S 10~30 LoC urgency:5 It is imperative that action be taken right away.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant