-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial version for install and run binaries #1112
Conversation
13d6097
to
9334fe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! Now I'm waiting for the docs 🙂
@@ -0,0 +1,223 @@ | |||
package main | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW I'd follow-up with your idea about wrapping such binaries + templates in dedicated plugins as it could be hard for someone to use flux
etc. 🤔 Do we have an issue for it already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can take this and discuss inside our team 👍
Description
Changes proposed in this pull request:
Testing
Create k3d cluster
Start plugin server:
env PLUGIN_SERVER_HOST=http://host.k3d.internal go run test/helpers/plugin_server.go
Build x plugin:
PLUGIN_TARGETS="x" make build-plugins
Install Botkube with such example config:
config yaml
Example Helm
Install helm CLI
Run Helm list
Example Flux
Install Flux CLI
Install Flux in cluster:
Create Source:
List sources:
Related issue(s)
Follow-ups
I will add two more built-in templates:
for
tutorial
, e.g. :Tutorial for Helm
for
wrapping
output:Wrapper
Breaking changes
I describe them already in our issue: #1116 (comment)