Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Botkube v1.2.0 #1116

Closed
4 tasks
mszostok opened this issue Jul 2, 2023 · 2 comments
Closed
4 tasks

Release Botkube v1.2.0 #1116

mszostok opened this issue Jul 2, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mszostok
Copy link
Contributor

mszostok commented Jul 2, 2023

Overview

This task aggregates all the to-dos which should be done when it comes to the release.

AC

@mszostok mszostok added the enhancement New feature or request label Jul 2, 2023
@mszostok mszostok added this to the v1.2.0 milestone Jul 2, 2023
@mszostok
Copy link
Contributor Author

mszostok commented Jul 2, 2023

Breaking changes


PR #1112

The pluginx.ExecuteCommand function signature was changed.

Old:

func ExecuteCommand(ctx context.Context, rawCmd string) (string, error)

New:

func ExecuteCommand(ctx context.Context, rawCmd string, mutators ...ExecuteCommandMutation) (ExecuteCommandOutput, error)

Reason
The ExecuteCommand function signature has changed to unify the command execution functions. The new signature allows for passing mutation functions to customize the execution and ensures future extensibility without breaking changes. Additionally, the introduction of the ExecuteCommandOutput type provides direct access to the stdout and stderr of the executed command. This is particularly useful when commands produce output on stderr even if they are not failed.


The pluginx.ExecuteCommandWithEnvs function has been deprecated. To achieve the same functionality, use pluginx.ExecuteCommand(ctx, "cmd", pluginx.ExecuteCommandEnvs(envs)).

@mszostok
Copy link
Contributor Author

mszostok commented Jul 14, 2023

Release activities

Other:

  • ⏳ Prepare the release notes

  • ⏳ Create a blog post and cross-post it (e.g. Medium, Dev.to)

  • ⏳ Share the news on social media (e.g. Reddit, Hacker News, LinkedIn, Twitter, Slack)

@pkosiec pkosiec closed this as completed Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants