Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump etcd newest version: v3.5.10 #121573

Merged
merged 1 commit into from
Nov 1, 2023
Merged

bump etcd newest version: v3.5.10 #121573

merged 1 commit into from
Nov 1, 2023
+756 −620

Conversation

tukwila
Copy link
Contributor

@tukwila tukwila commented Oct 27, 2023 •
edited by liggitt
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Refer to the issue:
etcd-io/etcd#16733

Command run:
bash hack/pin-dependency.sh go.etcd.io/etcd/api/v3 v3.5.10
bash hack/pin-dependency.sh go.etcd.io/etcd/client/pkg/v3 v3.5.10
bash hack/pin-dependency.sh go.etcd.io/etcd/client/v3 v3.5.10
bash hack/pin-dependency.sh go.etcd.io/etcd/pkg/v3 v3.5.10
bash hack/pin-dependency.sh go.etcd.io/etcd/raft/v3 v3.5.10
bash hack/pin-dependency.sh go.etcd.io/etcd/server/v3 v3.5.10

bash hack/lint-dependencies.sh 
go version go1.21.3 darwin/amd64
All pinned versions of checked dependencies match their preferred version.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 27, 2023
@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, aramase and a team October 27, 2023 14:44
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 27, 2023
@tukwila
Copy link
Contributor Author

tukwila commented Oct 27, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 27, 2023
@pacoxu
Copy link
Member

pacoxu commented Oct 30, 2023

/release-note-none
/assign @dims @liggitt
for dependency update

@k8s-ci-robot
Copy link
Contributor

@pacoxu: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none
/assign @dims @liggitt
for dependency update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt
Copy link
Member

liggitt commented Nov 1, 2023

/approve cancel

Just to prevent accidental merge until the unwanted-dependencies file is fixed. Sorry for the rebase trouble.

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
@tukwila
Copy link
Contributor Author

tukwila commented Nov 1, 2023

/approve cancel

Just to prevent accidental merge until the unwanted-dependencies file is fixed. Sorry for the rebase trouble.

yes, i'm working on it. -:)

@pacoxu
Copy link
Member

pacoxu commented Nov 1, 2023 •
edited
Loading

unwanted-dependencies now looks good to me. (But there are still some problem with CI. need to double check.)

  • however, the file is now 370+lines, compared with ~250 lines before

@pacoxu
Copy link
Member

pacoxu commented Nov 1, 2023

master...pacoxu:kubernetes:bump_etcd_v3.5.10#diff-09f70f26cff6c34dc0063a45ca43cf5025d653058b06f7966fc8e6f3b9cecd3eL231

only one line should be removed here.

@tukwila tukwila closed this Nov 1, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 1, 2023
@tukwila tukwila reopened this Nov 1, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 1, 2023
@tukwila
Copy link
Contributor Author

tukwila commented Nov 1, 2023

/retest

@MaryamTavakkoli
Copy link

Hello!
Bug triage for the 1.29 release cycle is here!
The code freeze will start (01:00 UTC Wednesday 1st November 2023 / 18:00 PDT Tuesday 31st October 2023). as we want to ensure that each PR has a chance to be merged.

Are we still targeting the 1.29 release?

@liggitt
Copy link
Member

liggitt commented Nov 1, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d02640664720e6d4cb4396fd971ef6b6368c8fb4

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tukwila

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9747358 into kubernetes:master Nov 1, 2023
19 checks passed
@mzaian mzaian mentioned this pull request Nov 2, 2023
Closed
4 tasks
@pacoxu pacoxu mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr left review comments

@serathius serathius serathius left review comments

@logicalhan logicalhan logicalhan left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@aramase aramase Awaiting requested review from aramase

@dims dims Awaiting requested review from dims

@liggitt liggitt Awaiting requested review from liggitt

@pacoxu pacoxu Awaiting requested review from pacoxu

Assignees

@dims dims

@liggitt liggitt

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubeadm area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG CLI
Archived in project
SIG Node: code and documentation PRs
Archived in project
[sig-release] Bug Triage
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
10 participants
@tukwila @pacoxu @k8s-ci-robot @liggitt @seans3 @dims @MaryamTavakkoli @logicalhan @serathius @ahrtr