Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

71: Fix volume mounting #72

Merged
merged 2 commits into from
Jan 31, 2024
Merged

71: Fix volume mounting #72

merged 2 commits into from
Jan 31, 2024

Conversation

yaraskm
Copy link
Contributor

@yaraskm yaraskm commented Jan 30, 2024

@yaraskm
71: Fix volume mounting
8444423 
- As outlined in kubereboot#71, trying to add a custom volumeMount will fail Helm
templating because the mount will be indented too far by two spaces.

- This was tested locally and resolves the templating issue.

Signed-off-by: Matt Yaraskavitch <[email protected]>
ckotzbauer
ckotzbauer requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@ckotzbauer ckotzbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you please update the version field in Chart.yaml too at patch-level?

@yaraskm
Bumped chart version as per PR review
ff476c5 
Signed-off-by: Matt Yaraskavitch <[email protected]>
@yaraskm
Copy link
Contributor Author

yaraskm commented Jan 31, 2024

Thanks, could you please update the version field in Chart.yaml too at patch-level?

Done! Thanks for the review @ckotzbauer

@ckotzbauer ckotzbauer merged commit f093eb9 into kubereboot:main Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckotzbauer ckotzbauer ckotzbauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaraskm @ckotzbauer