Generic wait-for-condition Condition #679
Conversation
Super unhappy with the API, but it's a start... Fixes kube-rs#669 Signed-off-by: Teo Klestrup Röijezon <[email protected]>
Signed-off-by: Teo Klestrup Röijezon <[email protected]>
| let serialized_obj = serde_json::to_value(obj).ok(); | ||
| status_cond.matches_object(serialized_obj.as_ref().and_then(|obj| { | ||
| obj.get("status")? | ||
| .get("conditions")? |
There was a problem hiding this comment.
Ideally we'd get around this with a HasConditions trait, but that would have to be upstream in k8s-openapi to be of much help
There was a problem hiding this comment.
I think those types of traits we'd need to define in the protobuf repo. I'll open some issues there to track.
| .as_array()? | ||
| .iter() | ||
| .find(|cond| { | ||
| cond.get("type").and_then(serde_json::Value::as_str) == Some(condition_type) | ||
| })? | ||
| .get("status")? | ||
| .as_str() |
There was a problem hiding this comment.
hah, I thought we were going ot start with DynamicObject first. This is pretty gross :D
| #[must_use] | ||
| pub fn unstable_has_status_condition<'a, K: Serialize + Resource, StatusCond: Condition<str> + 'a>( |
There was a problem hiding this comment.
Maybe we should look into something like https://docs.rs/stability/0.1.0/stability/attr.unstable.html rather than prefixing fn names
There was a problem hiding this comment.
That kind of makes sense. I'd almost rather have this be something that the end user has to opt into specifically with a --cfg, rather than a feature you can inherit by accident from a dependency.
There was a problem hiding this comment.
There is the tokio solution for this as well #508 (comment). Anyway, I've made notes about this in the big stability roadmap issue, because it's something we should solve for that.
| let serialized_obj = serde_json::to_value(obj).ok(); | ||
| status_cond.matches_object(serialized_obj.as_ref().and_then(|obj| { | ||
| obj.get("status")? | ||
| .get("conditions")? |
There was a problem hiding this comment.
I think those types of traits we'd need to define in the protobuf repo. I'll open some issues there to track.
| /// | ||
| /// ```rust | ||
| /// # use k8s_openapi::api::core::v1::{Pod, PodCondition, PodStatus}; | ||
| /// # use kube_runtime::wait::{conditions::unstable_has_status_condition, Condition}; |
There was a problem hiding this comment.
for reference; in docs you can use kube::runtime in doc paths for consistency. i've done this everywhere in all crates to refer to kube
There was a problem hiding this comment.
This is a doctest, which is built before the kube crate is. Either way, the line is hidden from readers (by prefixing with #).
| /// let cond_status_ready: fn(Option<&str>) -> bool = |status| status == Some("True"); | ||
| /// let cond_pod_ready = unstable_has_status_condition("Ready", cond_status_ready); |
There was a problem hiding this comment.
I almost feel like two &str inputs here are better than this closure. It's a struggle to understand why cond_status_ready needs so much wrapping from a consumer standpoint when all you are really doing here is passing in the value of an expected string.
There was a problem hiding this comment.
That doesn't cover something like |status| status == Some("Unknown") || status == Some("True"). It's also worth keeping in mind that status can ultimately be any string, the True/False/Unknown troolean is just a convention.
Then again, I'm not sure those advanced use-cases are something people actually want?
| .as_array()? | ||
| .iter() | ||
| .find(|cond| { | ||
| cond.get("type").and_then(serde_json::Value::as_str) == Some(condition_type) | ||
| })? | ||
| .get("status")? | ||
| .as_str() |
There was a problem hiding this comment.
hah, I thought we were going ot start with DynamicObject first. This is pretty gross :D
Co-authored-by: Eirik A <[email protected]>
Super unhappy with the API, but it's a start...
Fixes #669