-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define and implement equivalent k8s-openapi
traits
#4
Comments
This comment has been minimized.
This comment has been minimized.
Updated to reflect progress. |
k8s-openapi
traits
For #4 Signed-off-by: clux <[email protected]>
Have added There are potentially more improvements here, but starting out with the full verb soup generics is probably overkill. Closing this as sufficient to get going for now, but open to improvements in the future. |
A thing that can be done in parallel to the implementation of the code-generation, is to sketch out the traits we need to implement in the codegen, and whether we need to rethink them a bit.
There is currently a bit of a disparity between
k8s-openapi
traits andkube_core
's traits, and it would be nice if the traits we used inkube
, were the traits defined either bykube_core
or something here.So here's a rough list of generics I think we should aim to implement / refine for this project to be successful:
wanted traits
Need at least these two to be able to implement
kube::Resource
upstream:k8s-openapi::ResourceScope
equivalent. from old issue Resources are not scoped kube#194 - done in Add scope to theResource
trait #25k8s-openapi::Resource
equivalent - Add Traits #14 + Add scope to theResource
trait #25getter traits
HasSpec
andHasStatus
: https://github.com/kube-rs/kube-rs/blob/master/kube-core/src/object.rs - Add Traits #14HasConditions
: needed for things like Generic wait-for-condition Condition kube#679 - Add Traits #14HasMetadata
:: an analogue of thek8s_openapi::Metadata
trait - Add Traits #14There are probably room for more things, but we should decide where generics should live.
Here? Or separate repo? I'm leaning towards defining a
kube-traits
crate within thekube-rs
org and implementing it here.But open to ideas. Also, anything missing from this list?
Descoped
These could maybe be done later for even more generic action.
Log
- these should probably not live inkube-client
)The text was updated successfully, but these errors were encountered: