Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Traits #14

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Add Traits #14

merged 3 commits into from
Nov 3, 2021

Conversation

kazk
Copy link
Member

@kazk kazk commented Nov 3, 2021

A quick hack to add traits. It compiles :)

justfile Show resolved Hide resolved
@kazk kazk marked this pull request as ready for review November 3, 2021 10:03
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great. it allows us to start iterating on this properly.
one minor comment, but otherwise am just super happy to see this 👍

k8s-pb-codegen/src/main.rs Outdated Show resolved Hide resolved
Ok(())
}

fn append_trait_def(lib_rs: &mut File) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah, that is a nice way to get started. We can think about where to move this stuff later in #4

k8s-pb-codegen/src/main.rs Show resolved Hide resolved
k8s-pb-codegen/src/main.rs Show resolved Hide resolved
k8s-pb-codegen/src/main.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants