-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Api fns for arbitrary subresources and approval subresource for CertificateSigningRequest #773
Conversation
Signed-off-by: ChinYing-Li <[email protected]>
Signed-off-by: ChinYing-Li <[email protected]>
Signed-off-by: ChinYing-Li <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
- Coverage 71.99% 71.90% -0.09%
==========================================
Files 54 54
Lines 3631 3677 +46
==========================================
+ Hits 2614 2644 +30
- Misses 1017 1033 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey thanks again for all these prs!
i think the general setup here is ok, but have left a few comments on the main Api<CSR>
abstraction. I feel it is trying to make a few too many assumptions for what should be in kube-client
, and it's probably better to keep this simple and just wrap the newly added patch_subresource
method.
(however, there may be an argument here for replicating what kubectl certificate approve as a small certificate
helper in kube-runtime
- but that is not necessary for this pr - and not even sure we need to do it).
Signed-off-by: ChinYing-Li <[email protected]>
Signed-off-by: ChinYing-Li <[email protected]>
Signed-off-by: ChinYing-Li <[email protected]>
Signed-off-by: ChinYing-Li <[email protected]>
Signed-off-by: ChinYing-Li <[email protected]>
Signed-off-by: ChinYing-Li <[email protected]>
This looks great now. Thanks for doing all the minor tweaks here to get it into a great state! I'll merge this in tomorrow if you are happy with it :-) |
I think this is ready for merge. Thanks for helping! |
Motivation
This PR tackles two tasks in #127.
Solution
Implement Api functions for arbitrary subresource and Api approve/deny.
One test case of Api is added.
Should I try to come up with test cases for those
Api
subresource-related functions?IMO, testing the logic of
Request.*_subresource
should be sufficient.Any suggestion is appreciated!