feat: add ruby code block - heap sort #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @juminhong, please complete the check list. |
krahets
reviewed
Apr 10, 2024
| ### 堆的长度为 n ，从节点 i 开始，从顶至底堆化 ### | ||
| def sift_down(nums, n, i) | ||
| while true | ||
| # 判断节点i, l, r中值最大的节点，记为ma |
There was a problem hiding this comment.
It should be # 判断节点 i, l, r 中值最大的节点，记为 ma
Please ensure the comments are consistent with those in Python.
There was a problem hiding this comment.
sorry, I forgot this guide
9801c7a
krahets
reviewed
Apr 10, 2024
| ma = i | ||
| ma = l if l < n and nums[l] > nums[ma] | ||
| ma = r if r < n and nums[r] > nums[ma] | ||
| # 若节点i最大或索引l, r越界，则无须继续堆化，跳出 |
krahets
reviewed
Apr 10, 2024
| (nums.length / 2 - 1).downto(0) do |i| | ||
| sift_down(nums, nums.length, i) | ||
| end | ||
| # 从堆中提取最大元素，循环n-1轮 |
|
I'm curious why all the spaces in the comments were removed. Did you use a GPT-like tool? |
59 tasks
khoaxuantu
reviewed
Apr 10, 2024
| ### 堆的长度为 n ，从节点 i 开始，从顶至底堆化 ### | ||
| def sift_down(nums, n, i) | ||
| while true | ||
| # 判断节点 i, l, r 中值最大的节点，记为 ma |
There was a problem hiding this comment.
Please reduce the code to 2-space indentation
khoaxuantu
reviewed
Apr 24, 2024
Co-authored-by: khoaxuantu <[email protected]>
Co-authored-by: khoaxuantu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:
If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist:
result screenshot