Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove progress package (spinner) #1922

Merged
merged 5 commits into from
Aug 16, 2023

remove goroutine completely

941861d
Select commit
Loading
Failed to load commit list.
Merged

Remove progress package (spinner) #1922

remove goroutine completely
941861d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 16, 2023 in 0s

59.97% (-0.72%) compared to 1163a5e

View this Pull Request on Codecov

59.97% (-0.72%) compared to 1163a5e

Details

Codecov Report

Patch coverage: 55.31% and project coverage change: -0.72% ⚠️

Comparison is base (1163a5e) 60.69% compared to head (941861d) 59.97%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1922      +/-   ##
==========================================
- Coverage   60.69%   59.97%   -0.72%     
==========================================
  Files         107      106       -1     
  Lines       13819    13657     -162     
==========================================
- Hits         8387     8191     -196     
- Misses       4603     4620      +17     
- Partials      829      846      +17     
Files Changed Coverage Δ
pkg/pipelines/tekton/pipelines_provider.go 57.06% <25.00%> (+26.33%) ⬆️
pkg/functions/client.go 63.91% <85.00%> (-2.03%) ⬇️
cmd/client.go 88.15% <100.00%> (-0.60%) ⬇️
pkg/docker/pusher.go 65.00% <100.00%> (-1.27%) ⬇️

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.