-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove progress package (spinner) #1922
Conversation
cc @lkingland |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1922 +/- ##
==========================================
- Coverage 60.69% 59.97% -0.72%
==========================================
Files 107 106 -1
Lines 13819 13657 -162
==========================================
- Hits 8387 8191 -196
- Misses 4603 4620 +17
- Partials 829 846 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@gauron99 please try running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
Signed-off-by: gauron99 <[email protected]>
@matejvasek @lkingland PTAL guys, removed the goroutines and added the return value for URL as string. Not sure how to handle the structs in other files, where Run method is used so please let me know on that. I ran the test individually and collectively with |
Signed-off-by: gauron99 <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind removal
Fixes #1893
Fixes #1513