Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove progress package (spinner) #1922

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Conversation

gauron99
Copy link
Contributor

Changes

  • 🗑️ Remove feature or internal logic - remove spinner progress package, convert to printing to stderr instead as a first step to changing to a new logging package.

/kind removal
Fixes #1893
Fixes #1513

@knative-prow knative-prow bot added kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 10, 2023
@gauron99
Copy link
Contributor Author

cc @lkingland

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 55.31% and project coverage change: -0.72% ⚠️

Comparison is base (1163a5e) 60.69% compared to head (941861d) 59.97%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1922      +/-   ##
==========================================
- Coverage   60.69%   59.97%   -0.72%     
==========================================
  Files         107      106       -1     
  Lines       13819    13657     -162     
==========================================
- Hits         8387     8191     -196     
- Misses       4603     4620      +17     
- Partials      829      846      +17     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster 30.42% <36.17%> (?)
e2e-test-oncluster-runtime 25.29% <19.14%> (?)
e2e-test-runtime-go 25.65% <23.40%> (?)
e2e-test-runtime-node 26.66% <23.40%> (?)
e2e-test-runtime-python 26.66% <23.40%> (?)
e2e-test-runtime-quarkus 26.78% <23.40%> (?)
e2e-test-runtime-springboot 25.70% <23.40%> (?)
e2e-test-runtime-typescript 26.69% <23.40%> (?)
integration-tests 51.48% <48.93%> (+2.18%) ⬆️
unit-tests-macos-latest 48.24% <40.42%> (-0.03%) ⬇️
unit-tests-ubuntu-latest 49.03% <40.42%> (-0.03%) ⬇️
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/pipelines/tekton/pipelines_provider.go 57.06% <25.00%> (+26.33%) ⬆️
pkg/functions/client.go 63.91% <85.00%> (-2.03%) ⬇️
cmd/client.go 88.15% <100.00%> (-0.60%) ⬇️
pkg/docker/pusher.go 65.00% <100.00%> (-1.27%) ⬇️

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor

matejvasek commented Aug 10, 2023

@gauron99 please try running TestOnClusterBuild() locally.

@matejvasek matejvasek requested review from lkingland and removed request for maximilien and vyasgun August 10, 2023 16:15
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

pkg/functions/client.go Show resolved Hide resolved
pkg/functions/client.go Show resolved Hide resolved
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2023
@gauron99
Copy link
Contributor Author

@matejvasek @lkingland PTAL guys, removed the goroutines and added the return value for URL as string. Not sure how to handle the structs in other files, where Run method is used so please let me know on that. I ran the test individually and collectively with make test and both seem to work fine

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@knative-prow knative-prow bot merged commit ec6ee77 into knative:main Aug 16, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retiring the Spinner Spinner "clock" icon should be removed when operation finishes
3 participants