Add Multiple Options for Hole Configuration #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruudjhuu
approved these changes
Apr 18, 2024
|
I have an update to the printable option that uses the affine matrices, and I've found works better in Cura. Just completed yesterday, but I was debating how I wanted to back-port it. |
Everything now goes through block_base_hole(...) Noting in gridfinity-rebuilt-utility knows or cares what sytle_hole contains.
Similar to ljbeal's Pull Request. However, the implementation is completely different. kennetek#144
EmperorArthur
force-pushed
the
update_holes
branch
from
85a5a50
to
d35b006
Compare
Makes holes print better. Use Affine Translation Matrices to be clear how everything works without being too verbose.
Does not include all combinations.
EmperorArthur
force-pushed
the
update_holes
branch
from
d35b006
to
3e94c65
Compare
Helps prevent / minimize issues with filament droop.
Expecially when Cura decides to start the top of hole in mid-air.
Visible Changes:
* Supportless screw holes have a 3rd layer.
* Supportless magnet holes without screw holes have a 3rd layer.
Backend Changes:
* Switched to a completely different generation strategy.
* Previous strategy directly produced negative.
* New strategy is to make a positive,
then use that to create a negative.
* Algorithm for multiple layers is not perfect,
but works within tollerances set.
* These are not (yet) triggered/run by the CI/CD system.
EmperorArthur
force-pushed
the
update_holes
branch
2 times, most recently
from
f43b034
to
d1b3943
Compare
Used to ensure all hole options work.
May want to consider auto-generating these as part of the documentation build.
EmperorArthur
force-pushed
the
update_holes
branch
from
d1b3943
to
bdc5a7e
Compare
|
Ready for review/merge. Since the last review I have done the following:
Cura likes to print in mid-air if "top/bottom pattern" is set to "Concentric!" So the multiple printable layers help with droop and mitigate that bug. The test cases only run on Windows, but that's purely a hard-coded path issue. Once this is merged I will work on a PR for the CI/CD system, and add test case to prevent #180 from happening again. |
* Updated constant names to match previous changes.
This can be re-used for the baseplate.
Difference was small enough the slicer mostly ignored it.
Hole changes were not tested against it. Many oppertunities for improvements here.
Also fixes tests.
As opposed to being a parameter of `create_image`. Also made CameraArguments support fluent.
EmperorArthur
force-pushed
the
update_holes
branch
from
ad83728
to
a4807fd
Compare
It now also supports all the hole options. Note: Tests are not performed, due to the high rendering time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely re-works how holes for bins are created. Adding multiple options that can be mixed and matched.
Re-worked Features
The code for how these are generated has changed, but the output is the same.
refined_holes().gridfinityBase(...).New Features
That last one is admittedly pretty crazy, but there was no reason to prevent it. The only restriction is magnet holes don't work with refined holes, since they both do the same thing.
@Ruudjhuu This contains the pictures you were asking for in PR #144, but is incompatible with that PR.
There are additional pictures in the "images/base_hole_options/" folder.