Add option for a chamfered magnet holes #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you provide before and after screenshots (as a sanity check) I like the idea and want to approve the request. |
EmperorArthur
added a commit
to EmperorArthur/gridfinity-rebuilt-openscad
that referenced
this pull request
Apr 15, 2024
Actual implementation is completely different. kennetek#144
|
Close this for now due to #179 having the same feature with wanted extras. |
EmperorArthur
added a commit
to EmperorArthur/gridfinity-rebuilt-openscad
that referenced
this pull request
Apr 22, 2024
Similar to ljbeal's Pull Request. However, the implementation is completely different. kennetek#144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a customisable chamfer (defaults to 0.8mm) to the magnet holes. This counteracts any elephant's foot and makes magnet insertion easier in all cases (basically makes glue mandatory, though).
Works for all circular magnet holes, and with
only_corners.Set to 0 to disable.