Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that the default reap threshold is 30 days #66

Closed
wants to merge 2 commits into from
Closed

Clarify that the default reap threshold is 30 days #66

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f67043
Clarify that the default reap threshold is 30 days
MarkSRobinson May 29, 2022
302d1f0
Merge branch 'master' into patch-1
tekenstam Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/reaper/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ Flags:
--reap-after float Reaping threshold in minutes (default 10)
--reap-flappy Terminate nodes which have flappy readiness (default true)
--reap-old Terminate nodes older than --reap-old-threshold days
--reap-old-threshold-minutes int32 Reap N minute old nodes (default 30)
--reap-old-threshold-minutes int32 Reap N minute old nodes (default 30 days/43200 minutes)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flag already mentions minutes in this case the default value changed but the readme did not.
It should actually be

--reap-old-threshold-minutes int32   Reap N minute old nodes (default 43200)

This would actually show up correctly when you do ./governor reap node --help

--reap-old-throttle int Post terminate wait in seconds for old nodes (default 300)
--reap-throttle int Post terminate wait in seconds for unhealthy nodes(default 300)
--reap-unknown Terminate nodes where State = Unknown (default true)
Expand Down