Clarify that the default reap threshold is 30 days #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Robinson <[email protected]>
| @@ -124,7 +124,7 @@ Flags: | |||
| --reap-after float Reaping threshold in minutes (default 10) | |||
| --reap-flappy Terminate nodes which have flappy readiness (default true) | |||
| --reap-old Terminate nodes older than --reap-old-threshold days | |||
| --reap-old-threshold-minutes int32 Reap N minute old nodes (default 30) | |||
| --reap-old-threshold-minutes int32 Reap N minute old nodes (default 30 days/43200 minutes) | |||
There was a problem hiding this comment.
The flag already mentions minutes in this case the default value changed but the readme did not.
It should actually be
--reap-old-threshold-minutes int32 Reap N minute old nodes (default 43200)
This would actually show up correctly when you do ./governor reap node --help
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66 +/- ##
=======================================
Coverage 64.13% 64.13%
=======================================
Files 11 11
Lines 2136 2136
=======================================
Hits 1370 1370
Misses 669 669
Partials 97 97 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.