Skip to content

Commit

Permalink
Remove TODOs
Browse files Browse the repository at this point in the history
moved here: #1897 (comment)

Signed-off-by: Dimitris Karakasilis <[email protected]>
  • Loading branch information
jimmykarily committed Oct 24, 2023
1 parent 5d5e4e1 commit 2b9c943
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions .github/workflows/reusable-build-flavor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,17 +92,6 @@ jobs:
env:
VERSION: latest
run: |
# Desired artifact names:
# container image: quay.io/kairos/ubuntu:22.04-core-amd64-generic-v2.4.0
# iso: kairos-ubuntu-20.04-core-amd64-generic-v2.4.1-ipxe.iso
#
# TODO:
# - New branch:
# - Merge alma, rocky, fedora to one family dockerfile
# - Move rest of logic from Earthfile to Dockerfiles
# - Create a reusable worflow that simply calls docker build passing the required build-args
# - Delete the earthly base-image target and force the use of the above workflow anywhere needed
# - Make all remaining earthly targets to use a pre-cooked KAIROS_IMAGE rather than calling +base-image
earthly --platform=linux/${{ inputs.arch }} +ci \
--SECURITY_SCANS=false \
--VARIANT=${{ inputs.variant }} \
Expand Down

0 comments on commit 2b9c943

Please sign in to comment.