Skip to content

Commit

Permalink
Remove TODO (already implemented) and non-used ARG "IMAGE"
Browse files Browse the repository at this point in the history
Signed-off-by: Dimitris Karakasilis <[email protected]>
  • Loading branch information
jimmykarily committed Oct 24, 2023
1 parent 6f9c9e1 commit 5d5e4e1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -170,17 +170,14 @@ jobs:
VARIANT: ${{ matrix.variant }}
MODEL: ${{ matrix.model }}
BASE_IMAGE: ${{ matrix.baseImage }}
# TODO: Create a reusable script/workflow/something that generates the artifact name
# TODO: Use the naming.sh script
run: |
earthly +all \
--VARIANT=${{ matrix.variant }} \
--FAMILY=${{ matrix.family }} \
--FLAVOR=${{ matrix.flavor }} \
--FLAVOR=${{ matrix.flavorRelease }} \
--MODEL=${{ matrix.model }} \
--BASE_IMAGE=${{ matrix.baseImage }} \
--IMAGE=quay.io/kairos/${{ matrix.variant }}-${{ inputs.flavor }}-${{ matrix.model }}:latest
--BASE_IMAGE=${{ matrix.baseImage }}
sudo mv build release
- name: Push to quay
Expand Down
2 changes: 1 addition & 1 deletion Earthfile
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ iso-uki:

# This target builds an iso using a remote docker image as rootfs instead of building the whole rootfs
# This should be really fast as it uses an existing image. This requires a pushed image from the +image target
# defaults to use the $IMAGE name (so ttl.sh/core-opensuse-leap:latest)
# defaults to use the $REMOTE_IMG name (so ttl.sh/core-opensuse-leap:latest)
# you can override either the full thing by setting --REMOTE_IMG=docker:REPO/IMAGE:TAG
# or by --REMOTE_IMG=REPO/IMAGE:TAG
iso-remote:
Expand Down

0 comments on commit 5d5e4e1

Please sign in to comment.