Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin myst_parser to 0.11.2 to avoid no markdown_it.extensions.dollarmath #20

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Pin myst_parser to 0.11.2 to avoid no markdown_it.extensions.dollarmath #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/source/fixes/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ Then we could use React Intersection Obsever libraries.
- [React Intersection Observer (thebuilder)](https://github.com/thebuilder/react-intersection-observer) ([storybook](https://react-intersection-observer.now.sh))
- [React Intersection Observer (researchgate)](https://github.com/researchgate/react-intersection-observer) ([storybook](https://researchgate.github.io/react-intersection-observer))
- [React Cool Inview](https://github.com/wellyshen/react-cool-inview) ([example](https://react-cool-inview.netlify.app))
- [react-infinite-grid-scroller](https://github.com/HenrikBechmann/react-infinite-grid-scroller) (horizontal and vertical scrolling)

### React Virtualized / Windowing

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
],
# Note: This is only required for internal use
"rtd": [
"myst_parser",
"myst_parser==0.11.2",
"markdown-it-py~=0.4.5",
Copy link

@chrisjsewell chrisjsewell Aug 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is why! you should remove this line as its a dependancy clash with myst-parser 0.12

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also unpin sphinx from <3 if you want 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have done both and works locally. Will open another pr and hopefully rtd will be happy. Thx a lot!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! I guess it might depend on what version of pip you have, as to how it resolves the conflict

"pyyaml",
"docutils>=0.15",
Expand Down