Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin myst_parser to 0.11.2 to avoid no markdown_it.extensions.dollarmath #20

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

echarles
Copy link
Member

Yesterday myst-parser 0.12.0 has been published (https://pypi.org/project/myst-parser/0.12.0) and RTD build is failing with

    from myst_parser.main import default_parser, MdParserConfig
  File "/home/docs/checkouts/readthedocs.org/user_builds/jupyterlab-benchmarks/envs/latest/lib/python3.7/site-packages/myst_parser/main.py", line 13, in <module>
    from markdown_it.extensions.dollarmath import dollarmath_plugin
ModuleNotFoundError: No module named 'markdown_it.extensions.dollarmath'

Pinning to 0.11.2 to hopefully fix this

cc/ @choldgraf

Copy link
Member Author

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echarles
Copy link
Member Author

Yes, this fixes the issue.
I have opened executablebooks/MyST-Parser#220

@@ -42,7 +42,7 @@
],
# Note: This is only required for internal use
"rtd": [
"myst_parser",
"myst_parser==0.11.2",
"markdown-it-py~=0.4.5",
Copy link

@chrisjsewell chrisjsewell Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is why! you should remove this line as its a dependancy clash with myst-parser 0.12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also unpin sphinx from <3 if you want 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have done both and works locally. Will open another pr and hopefully rtd will be happy. Thx a lot!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! I guess it might depend on what version of pip you have, as to how it resolves the conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants