Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes to translations. #130

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Misc fixes to translations. #130

wants to merge 3 commits into from

Conversation

jonathf
Copy link
Owner

@jonathf jonathf commented Oct 21, 2017

From #125:
Add a -1 to auxillary variables when in Set.

From #126:
Bugfix for auxillary variables in Set.

From #128:
Reserved name Get_sum bugfix: vectorize:() -> vectorise::()

From #128 and #129:
Exploit equivalence of a (Var) and a(:) (Get, Colon) in MatLab to read the latter as the former.

@taiwuchian, let me know how these fixes works.

@codecov-io
Copy link

Codecov Report

Merging #130 into master will decrease coverage by 0.22%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   50.65%   50.43%   -0.23%     
==========================================
  Files          96       96              
  Lines        6947     6960      +13     
  Branches     1788     1792       +4     
==========================================
- Hits         3519     3510       -9     
- Misses       2975     3002      +27     
+ Partials      453      448       -5
Impacted Files Coverage Δ
src/matlab2cpp/node/frontend.py 94.44% <ø> (ø) ⬆️
src/matlab2cpp/rules/mat.py 3.7% <0%> (-3.06%) ⬇️
src/matlab2cpp/tree/variables.py 35.24% <100%> (+0.5%) ⬆️
src/matlab2cpp/node/backend.py 57.43% <100%> (+0.68%) ⬆️
src/matlab2cpp/rules/_reserved.py 23.01% <100%> (ø) ⬆️
src/matlab2cpp/rules/armadillo.py 57.37% <66.66%> (-6.56%) ⬇️
src/matlab2cpp/rules/cube.py 16.66% <0%> (-5.56%) ⬇️
src/matlab2cpp/configure/armadillo.py 16.88% <0%> (-3.9%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e4e87...6ab9331. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants