Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 3.5.0 release #1290

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

tim-schilling
Copy link
Contributor

Description

This is based off on #1289. I don't know how to chain PRs across repos in GitHub, so this may need to be cleaned up a bit. Or closed outright and redone.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@tim-schilling
Copy link
Contributor Author

@ddabble I merged a few dependency updates since they were pretty minimal. Hopefully that was alright by you. I updated the project for 5.0, dropped 4.1 in #1289. There's a bug fix from August that would be really helpful to my project so I wanted to help things along to make it easier for the next release. There looks to be a couple of other nice features since 3.4.0 as well.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (98b5225) 96.87% compared to head (bd15095) 96.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1290   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files          23       23           
  Lines        1278     1278           
  Branches      211      211           
=======================================
  Hits         1238     1238           
  Misses         21       21           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddabble
Copy link
Member

ddabble commented Dec 23, 2023

I merged a few dependency updates since they were pretty minimal. Hopefully that was alright by you.

You're more than welcome to do so! Any help maintaining is greatly appreciated 😄

I updated the project for 5.0, dropped 4.1 in #1289.

Nice, I'll take a look (and also check if there are more changes that should be done while upgrading to 5.0) once I have time, but I'm not sure I will before sometime after new year..


Btw, is it okay if I request reviews from you for some future PRs I have planned for this repo? 🙂

@tim-schilling
Copy link
Contributor Author

Btw, is it okay if I request reviews from you for some future PRs I have planned for this repo? 🙂

Yeah, feel free to request reviews from me in the future. I can't promise they'll be timely though 😁

@ddabble ddabble mentioned this pull request Feb 17, 2024
11 tasks
@ddabble
Copy link
Member

ddabble commented Feb 17, 2024

Great! 😊

I can't promise they'll be timely though 😁

No worries, and I guess I can also relate to that 😅

@ddabble
Copy link
Member

ddabble commented Feb 17, 2024

This is based off on #1289. I don't know how to chain PRs across repos in GitHub, so this may need to be cleaned up a bit. Or closed outright and redone.

I rebased on master, so it's good 🙂 But yeah, the usual method of setting the base branch to the branch of the PR you're basing it off, doesn't really work across repos, it seems 🤔

@ddabble ddabble mentioned this pull request Feb 17, 2024
11 tasks
@tim-schilling
Copy link
Contributor Author

Not a big deal. Next time if I want to do that, I'll create the branches on the repo.

@ddabble ddabble merged commit ac44d22 into jazzband:master Feb 19, 2024
22 checks passed
@ddabble
Copy link
Member

ddabble commented Feb 19, 2024

@treyhunner @rossmechanic Could one of you publish v3.5.0 to PyPI? 🙂

@tim-schilling tim-schilling deleted the version-3.5.0 branch February 20, 2024 01:13
@treyhunner
Copy link
Member

@treyhunner @rossmechanic Could one of you publish v3.5.0 to PyPI? 🙂

Done!

@ddabble ddabble added the release Pull requests that prepare for a new release label May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Pull requests that prepare for a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants