Add temporary asgiref requirement
#1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #1255 for discussion. Link to Django 4.1's required `asgiref` version: https://github.com/django/django/blob/4.1.11/setup.cfg#L42 Link to Django 4.2's required `asgiref` version: https://github.com/django/django/blob/4.2/setup.cfg#L42
Codecov Report
@@ Coverage Diff @@
## master #1261 +/- ##
=======================================
Coverage 96.94% 96.94%
=======================================
Files 23 23
Lines 1277 1277
Branches 210 210
=======================================
Hits 1238 1238
Misses 21 21
Partials 18 18 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
valberg
approved these changes
Sep 26, 2023
|
Would it be possible to get a release out including this change? |
|
Sure, working on a release PR (#1290) right now 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1209 added an implicit dependency on
asgiref>=3.6, as the imported functioniscoroutinefunction()was introduced inasgiref3.6.0 (seeasgiref's changelog), but a lower version is the minimum requirement of Django 4.1 and earlier (see e.g. Django 4.1.11'ssetup.cfg).This means that users who happen to install
django-simple-historytogether with Django 4.1 or lower, might implicitly also install a lower version ofasgirefthan what's actually required to run our code.The easiest solution to this seems to be adding a requirement for
asgiref>=3.6, which can be removed when our minimum required Django version is 4.2 or higher.Related Issue
Closes #1255.
Motivation and Context
See the discussion of the issue linked above.
How Has This Been Tested?
Through GitHub actions.
Screenshots (if appropriate):
Types of changes
asgirefas is installed with the Django version they're usingChecklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst