forked from ros2/rclcpp
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for actions - Do not merge! #51
Open
mauropasse
wants to merge
220
commits into
irobot-ros:irobot/add-events-executor
Choose a base branch
from
mauropasse:mauro/actions-support-2
base: irobot/add-events-executor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for actions - Do not merge! #51
mauropasse
wants to merge
220
commits into
irobot-ros:irobot/add-events-executor
from
mauropasse:mauro/actions-support-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id-ptr Check validity of executor pointer
use void * to pass executor ptr
…-executor Proper spin_some behaviour on EventsExecutor
Signed-off-by: Alberto Soragna <[email protected]>
remove smart pointer definitions for virtual class
Signed-off-by: Alberto Soragna <[email protected]>
Signed-off-by: Alberto Soragna <[email protected]>
Signed-off-by: Soragna, Alberto <[email protected]>
Signed-off-by: Soragna, Alberto <[email protected]>
Asoragna/cleanup
Rework executor callback data
irobot-ros
force-pushed
the
irobot/add-events-executor
branch
from
March 12, 2021 13:26
0d50b6c
to
48416d3
Compare
Signed-off-by: Mauro Passerino <[email protected]>
irobot-ros
force-pushed
the
irobot/add-events-executor
branch
from
March 16, 2021 11:22
48416d3
to
91668ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR for reference, since the actions support should live in a different branch than
irobot/add-events-executor
Goes together with irobot-ros/rcl#17