chore: update README and package.json #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for brilliant-pasca-3e80ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
pkg: documentation
mkurapov
reviewed
Oct 13, 2023
| @@ -8,21 +8,21 @@ This website is built with [Starlight](https://starlight.astro.build/), a docume | |||
|
|
|||
| ### Local Development | |||
|
|
|||
| - Make sure all the dependencies for the website are installed: | |||
| - Make sure all the dependencies for the website are installed. Because this is a monorepo, you should run the following command in the root of the project folder: | |||
There was a problem hiding this comment.
Maybe something like "should run the following in this project folder (/packages/documentation)" to differentiate from the "root"
There was a problem hiding this comment.
I just assumed the person would install the dependencies throughout the repo. Because when we make changes to the dependencies on the repo, the pnpm-lock is updated outside the repo anyway.
packages/documentation/package.json
Outdated
| "@types/react": "^18.2.28", | ||
| "@types/react-dom": "^18.2.13", | ||
| "astro": "3.2.3", | ||
| "@interledger/docs-design-system": "^0.1.0", |
huijing
force-pushed
the
chj/2025/update-dependencies-and-readme
branch
from
080d71c to
1e7477b
Compare
raducristianpopa
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, Playwright just updated itself, so the ridiculous build issue on Netlify is bacccckkkkkk. Given that Playwright did the release on 12 Oct 2023, we should take note of the time it takes for Netlify deploy to clear its cache.
Update: the pipeline turned green on 19 Oct 2023
The same has happened to our docs-styleguide as well on the Github pipeline, refer to interledger/docs-styleguide#7. We should take note of how long Github takes to clear its cache as well.
Changes proposed in this pull request
Context
Closes #2025
Checklist
fixes #number