Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright issue for Mermaid support is disruptive #22

Closed
huijing opened this issue Nov 29, 2023 · 0 comments · Fixed by interledger/docs-design-system#13
Closed

Playwright issue for Mermaid support is disruptive #22

huijing opened this issue Nov 29, 2023 · 0 comments · Fixed by interledger/docs-design-system#13
Assignees
Labels
enhancement New feature or request

Comments

@huijing
Copy link
Contributor

huijing commented Nov 29, 2023

In order to add support for Mermaid diagrams in markdown, we made use of https://github.com/remcohaszing/remark-mermaidjs, which has a Playwright dependency under the hood. As it turns out, there is a very known issue around Playwright and browser versioning: https://gkushang.medium.com/playwright-failed-to-launch-browsers-how-to-solve-8b01d03fe5b9

And everyone seems to run into this issue regularly, but no one has a tried and tested way of ensuring it doesn't recur. Many solutions target Docker since that seems to be the predominant use-case but our static hosting solutions of Netlify and GitHub pages limit our configuration options.

For context, see #7 and interledger/rafiki#2026

TLDR, this is not ideal, we are not even using Playwright directly. The logical course of action is to see if we can NOT use the plugin and roll our own Mermaid component directly using the library. The implication is that this will be a client-side solution, therefore we will also assess the performance implication of doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant