🐛 💥 Fix message_base size #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukevalenty
requested changes
Jul 12, 2023
mjcaisse-intel
approved these changes
Jul 12, 2023
`message_base` size was not set correctly when constructing from a range or a variadic pack of integral types. Remove message_base NumDWords template parameter: there was no need for it.
bdeane-intel
force-pushed
the
fix-message-base-size
branch
from
afec066
to
80290b3
Compare
lukevalenty
approved these changes
Jul 12, 2023
herculanodavi
added a commit
to herculanodavi/compile-time-init-build
that referenced
this pull request
Jul 16, 2023
Add `MaxDWordExtent` member to `disjoint_field` to fulfill the requirement introduced by intel#320. Add `ValueType` alias to `disjoint_field`.
This was referenced Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
message_basesize was not set correctly when constructing from a range or a variadic pack of integral types.Remove message_base NumDWords template parameter: there was no need for it.
Closes #317