You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The msg::disjoint_field is very useful to me, but I'm going through the problems below and would be happy to make a PR with these changes:
Add access to the DWordIndex of the contained types
When making a message that uses only msg::field (and no msg::disjoint_field), it is normally easy to calculate the necessary message size, since it should be 1 + std::max({FieldsT::DWordIndex...}) (considering we start always from zero), when FieldsT is the template parameter pack of the message fields.
It's not easy, though, to perform this when using messages with msg::disjoint_field because the inner fields are not provided as a type alias and the fields variable is private.
Could a public type alias to FieldsT be provided to make this calculation possible? Or maybe a method that returns a list of DWordIndex of every type?
Add ValueType alias
Same situation as 1, but now for making templates that use the ValueType field. It is avaliable in msg::field but not in msg::disjoint_field, even though it is one of the template arguments.
Could a public alias to T, say, using ValueType = T be provided?
The text was updated successfully, but these errors were encountered:
The
msg::disjoint_field
is very useful to me, but I'm going through the problems below and would be happy to make a PR with these changes:Add access to the DWordIndex of the contained types
When making a message that uses only
msg::field
(and nomsg::disjoint_field
), it is normally easy to calculate the necessary message size, since it should be1 + std::max({FieldsT::DWordIndex...})
(considering we start always from zero), whenFieldsT
is the template parameter pack of the message fields.It's not easy, though, to perform this when using messages with
msg::disjoint_field
because the inner fields are not provided as a type alias and thefields
variable is private.Could a public type alias to
FieldsT
be provided to make this calculation possible? Or maybe a method that returns a list ofDWordIndex
of every type?Add ValueType alias
Same situation as 1, but now for making templates that use the
ValueType
field. It is avaliable inmsg::field
but not inmsg::disjoint_field
, even though it is one of the template arguments.Could a public alias to
T
, say,using ValueType = T
be provided?The text was updated successfully, but these errors were encountered: