Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChainId to Starknet and Comet client state #173

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Add ChainId to Starknet and Comet client state #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
67573b0
Add ChainId to CometClientState
ljoss17 Jan 8, 2025
b21de5c
use MutEncoder and MutDecoder
rnbguy Jan 8, 2025
dc55653
Fix clippy
ljoss17 Jan 8, 2025
ecb9b21
Update CometClientState in Cairo to add chain_id field
ljoss17 Jan 9, 2025
e161183
Add chain ID type to StarknetClientState as Felt type
ljoss17 Jan 10, 2025
7467f31
Use String in Rust code for Chain ID in Starknet client state
ljoss17 Jan 10, 2025
70009d7
Remove unnecessary Felt to Protobuf wiring
ljoss17 Jan 10, 2025
7ced046
Replace remaining Felt chainID types to String
ljoss17 Jan 10, 2025
546bd98
use ChainId for chain_id type
rnbguy Jan 10, 2025
9904ef4
debug: this compiles
rnbguy Jan 10, 2025
8fa350e
wire ChainId encoding
rnbguy Jan 10, 2025
e0ad541
add cgp trait bounds
rnbguy Jan 10, 2025
848eab5
comment ChainId cgp bound which does not work
rnbguy Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cairo-contracts/packages/clients/src/cometbft/client_state.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@ use core::num::traits::Zero;
use starknet_ibc_clients::cometbft::CometErrors;
use starknet_ibc_core::client::{Height, HeightPartialOrd, Status, StatusTrait};

#[derive(Clone, Debug, Drop, Hash, PartialEq, Serde, starknet::Store)]
#[derive(Clone, Debug, Drop, PartialEq, Serde, starknet::Store)]
pub struct CometClientState {
pub latest_height: Height,
pub trusting_period: u64,
pub unbonding_period: u64,
pub status: Status,
pub chain_id: ByteArray,
}

#[generate_trait]
Expand Down
1 change: 1 addition & 0 deletions cairo-contracts/packages/testkit/src/configs/cometbft.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ pub impl CometClientConfigImpl of CometClientConfigTrait {
trusting_period: *self.trusting_period,
unbonding_period: *self.unbonding_period,
status: Status::Active,
chain_id: "dummy_chain",
};

Serde::serialize(@client_state, ref serialized_client_state);
Expand Down
Loading
Loading