Add ChainId to Starknet and Comet client state #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnbguy
force-pushed
the
luca_joss/add-chain-id-field-to-client-state
branch
from
b8dcf58 to
ae71a7b
Compare
rnbguy
force-pushed
the
luca_joss/add-chain-id-field-to-client-state
branch
from
ae71a7b to
546bd98
Compare
rnbguy
force-pushed
the
luca_joss/add-chain-id-field-to-client-state
branch
from
31af839 to
9904ef4
Compare
rnbguy
reviewed
Jan 10, 2025
| @@ -190,6 +190,7 @@ pub trait CanUseStarknetLightClientEncoding: | |||
| + CanConvertBothWays<Any, StarknetHeader> | |||
| + CanEncodeAndDecodeMut<ViaProtobuf, Timestamp> | |||
| + CanEncodeAndDecodeMut<ViaProtobuf, CommitmentRoot> | |||
| // + CanEncodeAndDecodeMut<ViaProtobuf, ChainId> | |||
There was a problem hiding this comment.
Uncommenting this line fails our build.
Specifically, CanEncodeAndDecodeMut<ViaProtobuf, ChainId> doesn't satisfy.
rnbguy
reviewed
Jan 10, 2025
Comment on lines
+185
to
+213
| pub struct EncodeChainId; | ||
|
|
||
| impl<Encoding, Strategy> MutEncoder<Encoding, Strategy, ChainId> for EncodeChainId | ||
| where | ||
| Encoding: CanEncodeMut<Strategy, String>, | ||
| { | ||
| fn encode_mut( | ||
| encoding: &Encoding, | ||
| chain_id: &ChainId, | ||
| buffer: &mut Encoding::EncodeBuffer, | ||
| ) -> Result<(), Encoding::Error> { | ||
| let chain_id_str = chain_id.as_str().to_string(); | ||
| encoding.encode_mut(&chain_id_str, buffer)?; | ||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| impl<Encoding, Strategy> MutDecoder<Encoding, Strategy, ChainId> for EncodeChainId | ||
| where | ||
| Encoding: CanDecodeMut<Strategy, String> + CanRaiseError<&'static str>, | ||
| { | ||
| fn decode_mut<'a>( | ||
| encoding: &Encoding, | ||
| buffer: &mut Encoding::DecodeBuffer<'a>, | ||
| ) -> Result<ChainId, Encoding::Error> { | ||
| let chain_id_str = encoding.decode_mut(buffer)?; | ||
| ChainId::new(&chain_id_str).map_err(|_| Encoding::raise_error("invalid chain id")) | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this correct to satisfy CanEncodeAndDecodeMut<ViaProtobuf, ChainId>?
rnbguy
reviewed
Jan 10, 2025
Comment on lines
+25
to
+28
| // EncodeField< | ||
| // symbol!("chain_id"), | ||
| // EncodeLengthDelimitedProtoField<2, UseContext>, | ||
| // >, |
There was a problem hiding this comment.
The commented out parts in this file are done the same way as EncodeStarknetConsensusState and EncodeStarknetHeader. Not sure why this doesn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #147
Status
chain_idfield toCometClientStatein relayer codechain_idfield toCometClientStatein Cairo codechain_idfield toStarknetClientStatein relayer codechain_idfield toStarknetClientStatein Cairo code