Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically changing tooltipBgColor #1595

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

xvrh
Copy link
Contributor

@xvrh xvrh commented Feb 29, 2024

This PR is to replace this one: #1348.

All credits goes to @apekshamehta

Original description:

Changes Made:

In the bar_chart_data.dart file:

Added a new parameter getTooltipColor to the constructor of BarTouchTooltipData.
Defined a new type GetBarTooltipColor, which is a function that takes a BarChartGroupData parameter and returns a Color.
In the bar_chart_painter.dart file:

Assigned the tooltip color to the _bgTouchTooltipPaint.color property using the getTooltipColor function from the tooltipData object.
Additionally, the getTooltipColor function has been utilized in the bar_chart_sample1.dart file within the feature/dynamic-tooltip-bgcolor branch.

Please review the changes for this pull request.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.52%. Comparing base (34a6af0) to head (526c16a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1595      +/-   ##
==========================================
+ Coverage   87.51%   87.52%   +0.01%     
==========================================
  Files          45       45              
  Lines        3075     3078       +3     
==========================================
+ Hits         2691     2694       +3     
  Misses        384      384              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pubspec.yaml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@imaNNeo
Copy link
Owner

imaNNeo commented Mar 28, 2024

There are some minor changes. Please fix them, then It is ready to be merged!

@xvrh xvrh force-pushed the feature/dynamic-tooltip-bgcolor branch from f34c4b4 to bb17761 Compare March 28, 2024 21:13
@imaNNeo imaNNeo merged commit bfdd91b into imaNNeo:main Mar 28, 2024
4 checks passed
@imaNNeo
Copy link
Owner

imaNNeo commented Mar 28, 2024

Thanks for your quick response and action!
I hope to see more from you xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants