-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically changing tooltipBgColor #1595
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1595 +/- ##
==========================================
+ Coverage 87.51% 87.52% +0.01%
==========================================
Files 45 45
Lines 3075 3078 +3
==========================================
+ Hits 2691 2694 +3
Misses 384 384 ☔ View full report in Codecov by Sentry. |
imaNNeo
reviewed
Mar 28, 2024
imaNNeo
reviewed
Mar 28, 2024
imaNNeo
reviewed
Mar 28, 2024
example/lib/presentation/samples/scatter/scatter_chart_sample2.dart
Outdated
Show resolved
Hide resolved
imaNNeo
reviewed
Mar 28, 2024
imaNNeo
reviewed
Mar 28, 2024
imaNNeo
reviewed
Mar 28, 2024
imaNNeo
reviewed
Mar 28, 2024
There are some minor changes. Please fix them, then It is ready to be merged! |
xvrh
force-pushed
the
feature/dynamic-tooltip-bgcolor
branch
from
March 28, 2024 21:13
f34c4b4
to
bb17761
Compare
Thanks for your quick response and action! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to replace this one: #1348.
All credits goes to @apekshamehta
Original description:
Changes Made:
In the bar_chart_data.dart file:
Added a new parameter getTooltipColor to the constructor of BarTouchTooltipData.
Defined a new type GetBarTooltipColor, which is a function that takes a BarChartGroupData parameter and returns a Color.
In the bar_chart_painter.dart file:
Assigned the tooltip color to the _bgTouchTooltipPaint.color property using the getTooltipColor function from the tooltipData object.
Additionally, the getTooltipColor function has been utilized in the bar_chart_sample1.dart file within the feature/dynamic-tooltip-bgcolor branch.
Please review the changes for this pull request.