Dynamically changing tooltipBgColor #1348

apekshamehta · 2023-05-26T13:03:52Z

Changes Made:

In the bar_chart_data.dart file:

Added a new parameter getTooltipColor to the constructor of BarTouchTooltipData.
Defined a new type GetBarTooltipColor, which is a function that takes a BarChartGroupData parameter and returns a Color.

In the bar_chart_painter.dart file:

Assigned the tooltip color to the _bgTouchTooltipPaint.color property using the getTooltipColor function from the tooltipData object.

Additionally, the getTooltipColor function has been utilized in the bar_chart_sample1.dart file within the feature/dynamic-tooltip-bgcolor branch.

Please review the changes for this pull request.

lib/src/chart/bar_chart/bar_chart_data.dart

imaNNeo · 2023-06-07T21:07:57Z

Please read our contributing guidelines carefully
Please update our CHANGELOG
Please update our docs (bar_chart.md)
Please do the same for other axis-based charts such as line chart and scatter chart

codecov · 2023-06-07T21:14:30Z

Codecov Report

Merging #1348 (274d888) into master (c8dc3c0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1348      +/-   ##
==========================================
+ Coverage   86.62%   86.64%   +0.01%     
==========================================
  Files          45       45              
  Lines        3014     3017       +3     
==========================================
+ Hits         2611     2614       +3     
  Misses        403      403

Files	Coverage Δ
lib/src/chart/bar_chart/bar_chart_painter.dart	`96.12% <100.00%> (ø)`
lib/src/chart/line_chart/line_chart_painter.dart	`92.09% <100.00%> (+0.04%)`	⬆️
...src/chart/scatter_chart/scatter_chart_painter.dart	`85.39% <100.00%> (ø)`

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

apekshamehta · 2023-06-13T16:55:54Z

Please read our contributing guidelines carefully

Please update our CHANGELOG

Please update our docs (bar_chart.md)

Please do the same for other axis-based charts such as line chart and scatter chart

Ok i am starting with first 3 points. Will continue with 4th point once i get confirmation for the change i have made for the bar chart.

imaNNeo · 2023-06-14T18:18:44Z

I've answered

apekshamehta · 2023-06-22T18:18:02Z

I have done all the

Please read our contributing guidelines carefully

Please update our CHANGELOG

Please update our docs (bar_chart.md)

Please do the same for other axis-based charts such as line chart and scatter chart

this is also done. please review and close the pr. also in the meantime did get a good grasp on dart. so open to some exciting new issues that are of priority. thanks @imaNNeo

lib/src/chart/bar_chart/bar_chart_data.dart

lib/src/chart/scatter_chart/scatter_chart_painter.dart

repo_files/documentations/bar_chart.md

repo_files/documentations/line_chart.md

repo_files/documentations/scatter_chart.md

pubspec.yaml

CHANGELOG.md

example/lib/presentation/samples/bar/bar_chart_sample1.dart

test/chart/line_chart/line_chart_painter_test.dart

lib/src/chart/bar_chart/bar_chart_data.dart

imaNNeo · 2023-07-31T22:40:30Z

I think you also need a rebase,
After that, we are ready to merge it.
Thanks in advance!

imaNNeo · 2023-08-22T08:55:30Z

I think you need to rebase your branch.

imaNNeo · 2023-09-14T23:50:16Z

You should rebase your branch. So when you merge master into your branch you cannot rebase anymore.
Please fix your commits (you can reset your branch and commit your changes again and then you can force push to override the remote commits)

…each rod in a bar chart.

…catter chart

…ter Charts, Added new method called getTooltipColor for which user can provide their own custom implementation to change backgroud color for each tooltip of given chart, Updated sample charts, Updated test cases, Updated bar_chart.md,line_chart.md and scatter_chart.md files for the brief description about new method, Updated version code in pubspec

…lass. reverted back to the previous version which was 0.63.0. changed default color specification in all charts md files.

…ter Charts, Added new method called getTooltipColor for which user can provide their own custom implementation to change backgroud color for each tooltip of given chart, Updated sample charts, Updated test cases, Updated bar_chart.md,line_chart.md and scatter_chart.md files for the brief description about new method, Updated version code in pubspec

…lass. reverted back to the previous version which was 0.63.0. changed default color specification in all charts md files.

…tooltip background color in handle_touches.md file

…each rod in a bar chart.

…ter Charts, Added new method called getTooltipColor for which user can provide their own custom implementation to change backgroud color for each tooltip of given chart, Updated sample charts, Updated test cases, Updated bar_chart.md,line_chart.md and scatter_chart.md files for the brief description about new method, Updated version code in pubspec

…lass. reverted back to the previous version which was 0.63.0. changed default color specification in all charts md files.

…ter Charts, Added new method called getTooltipColor for which user can provide their own custom implementation to change backgroud color for each tooltip of given chart, Updated sample charts, Updated test cases, Updated bar_chart.md,line_chart.md and scatter_chart.md files for the brief description about new method, Updated version code in pubspec

…lass. reverted back to the previous version which was 0.63.0. changed default color specification in all charts md files.

…tooltip background color in handle_touches.md file

…apekshamehta/fl_chart into pr/1348

imaNNeo · 2023-11-05T13:15:35Z

Hi, I'm sorry I think I ruined something here :)
I wanted to rebase your branch and resolve the new conflicts, but I have stolen your commits and everything is in my name.
Can you please create a fresh PR and commit everything to your name?

apekshamehta · 2023-12-22T06:21:47Z

Hi, I'm sorry I think I ruined something here :) I wanted to rebase your branch and resolve the new conflicts, but I have stolen your commits and everything is in my name. Can you please create a fresh PR and commit everything to your name?

@imaNNeo Hey,I am really sorry for the delay. will complete this by today.

xvrh · 2024-02-16T15:40:15Z

@apekshamehta @imaNNeo I'm interested in this feature.
I rebased and squashed the work of this branch here: https://github.com/xvrh/fl_chart/commits/feature/dynamic-tooltip-bgcolor/
How can we move this forward to be merged?

Thanks!

apekshamehta · 2024-02-17T06:30:27Z

@apekshamehta @imaNNeo I'm interested in this feature. I rebased and squashed the work of this branch here: https://github.com/xvrh/fl_chart/commits/feature/dynamic-tooltip-bgcolor/ How can we move this forward to be merged?

Thanks!

I have tested the changes and they are working as expected let's get this merged

imaNNeo · 2024-02-28T22:38:03Z

This PR contains 80 wrong commits (my bad).
Can you please create a new PR with your single commit?

imaNNeo · 2024-02-28T22:38:22Z

Don't forget to mention this PR to have it in the history if you created a new one

xvrh · 2024-02-29T06:36:59Z

PR created here: #1595

imaNNeo reviewed Jun 7, 2023

View reviewed changes

lib/src/chart/bar_chart/bar_chart_data.dart Show resolved Hide resolved

imaNNeo reviewed Jul 6, 2023

View reviewed changes

lib/src/chart/bar_chart/bar_chart_data.dart Outdated Show resolved Hide resolved

imaNNeo reviewed Jul 6, 2023

View reviewed changes

lib/src/chart/scatter_chart/scatter_chart_painter.dart Outdated Show resolved Hide resolved

imaNNeo reviewed Jul 6, 2023

View reviewed changes

repo_files/documentations/bar_chart.md Outdated Show resolved Hide resolved

imaNNeo reviewed Jul 6, 2023

View reviewed changes

repo_files/documentations/line_chart.md Outdated Show resolved Hide resolved

imaNNeo reviewed Jul 6, 2023

View reviewed changes

repo_files/documentations/scatter_chart.md Outdated Show resolved Hide resolved

imaNNeo reviewed Jul 6, 2023

View reviewed changes

pubspec.yaml Outdated Show resolved Hide resolved

imaNNeo reviewed Jul 6, 2023

View reviewed changes

CHANGELOG.md Show resolved Hide resolved