Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using LibmeshPetscCall wrapper macros #28929

Draft
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

nmnobre
Copy link
Member

@nmnobre nmnobre commented Oct 24, 2024

Hi @lindsayad,

Reason and Design

Same as that of libMesh/libmesh#3973.
Shortens the code and allows exception throwing.

I'm missing LIBMESH_CHKERR, I'll do that in another PR, I suspect this will be enough for a few CI problems already.

Cheers,
-N

@moosebuild
Copy link
Contributor

Job Precheck, step Clang format on 9868bf1 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/28929/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format c3b0e9824ea495b343ac3a3f0ba633e25b584e2d

nmnobre added a commit to farscape-project/moose that referenced this pull request Oct 24, 2024
@nmnobre nmnobre marked this pull request as draft October 24, 2024 23:35
nmnobre added a commit to farscape-project/moose that referenced this pull request Oct 24, 2024
@@ -1 +1 @@
Subproject commit 5483644b60cc538a4b54d312f28835bd94107627
Subproject commit 09466ba6fa7df01e88e87f0c9d2945d103099440
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

@moosebuild
Copy link
Contributor

Job Precheck, step Conda libmesh build config check on 0e04814 wanted to post the following:

A change of the following file(s) triggered this check:

libmesh

The following file(s) are unchanged:

conda/mpi/conda_build_config.yaml
conda/libmesh/meta.yaml

The libmesh submodule or configuration was changed but the conda build config was not

@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on 0e04814 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on 0e04814 wanted to post the following:

Framework coverage

c3b0e9 #28929 0e0481
Total Total +/- New
Rate 85.06% 85.12% +0.06% 60.77%
Hits 106401 106207 -194 189
Misses 18681 18559 -122 122

Diff coverage report

Full coverage report

Modules coverage

External petsc solver

c3b0e9 #28929 0e0481
Total Total +/- New
Rate 86.25% 85.04% -1.22% 96.43%
Hits 389 341 -48 54
Misses 62 60 -2 2

Diff coverage report

Full coverage report

Navier stokes

c3b0e9 #28929 0e0481
Total Total +/- New
Rate 84.64% 84.62% -0.02% 97.06%
Hits 17081 17048 -33 33
Misses 3100 3098 -2 1

Diff coverage report

Full coverage report

Optimization

c3b0e9 #28929 0e0481
Total Total +/- New
Rate 88.55% 88.61% +0.06% 87.69%
Hits 1972 1922 -50 57
Misses 255 247 -8 8

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 60.77% is less than the suggested 90.0%
  • optimization new line coverage rate 87.69% is less than the suggested 90.0%

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants