-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using LibmeshPetscCall wrapper macros #28929
base: next
Are you sure you want to change the base?
Conversation
Job Precheck, step Clang format on 9868bf1 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
@@ -1 +1 @@ | |||
Subproject commit 5483644b60cc538a4b54d312f28835bd94107627 | |||
Subproject commit 09466ba6fa7df01e88e87f0c9d2945d103099440 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution! This contains a submodule update
Job Precheck, step Conda libmesh build config check on 0e04814 wanted to post the following: A change of the following file(s) triggered this check: libmesh The following file(s) are unchanged: conda/mpi/conda_build_config.yaml The libmesh submodule or configuration was changed but the conda build config was not |
Job Documentation, step Docs: sync website on 0e04814 wanted to post the following: View the site here This comment will be updated on new commits. |
Job Coverage, step Generate coverage on 0e04814 wanted to post the following: Framework coverage
Modules coverageExternal petsc solver
Navier stokes
Optimization
Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
0e04814
to
2e92367
Compare
Hi @lindsayad,
Reason and Design
Same as that of libMesh/libmesh#3973.
Shortens the code and allows exception throwing.
I'm missing
LIBMESH_CHKERR
, I'll do that in another PR, I suspect this will be enough for a few CI problems already.Cheers,
-N