Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate key #1000

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Remove duplicate key #1000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
946100e
fix(index.js): remove duplicate
AdrianaCeric Nov 9, 2023
035f411
fix(index.js): update todos
AdrianaCeric Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions lib/types/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export type RtdEntity = {
export type RtdAlert = {
Cause: string,
DescriptionText: string,
DescriptionText: string,
EditedBy: string,
EditedDate: string,
Effect: string,
Expand Down Expand Up @@ -238,8 +237,7 @@ export type CustomFile = {
useDuringServe: boolean
}

// TODO: Remove this eslint rule once https://github.com/babel/babel-eslint/pull/584
// is merged in.
// TODO: Remove this eslint rule once Mastarm is upgraded/replaced
/* eslint-disable no-use-before-define */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to remove this too since the PR above is merged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have an old version of flow since I still go the pre-commit lint error when I removed this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok we should change the TODO then to be updating eslint rather than waiting for the PR to be merged. I think the TODO is still relevant as long as the error is thrown

export type Deployment = {
buildGraphOnly?: boolean,
Expand Down Expand Up @@ -576,8 +574,7 @@ export type Label = {
user?: string
}

// TODO: Remove this eslint rule once https://github.com/babel/babel-eslint/pull/584
// is merged in.
// TODO: Remove this eslint rule once Mastarm is upgraded/replaced
/* eslint-enable no-use-before-define */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise

export type FeedInfo = {
id: string
Expand Down
Loading