Remove duplicate key #1000
Merged
Remove duplicate key #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philip-cline
approved these changes
Nov 9, 2023
| @@ -238,8 +237,6 @@ export type CustomFile = { | |||
| useDuringServe: boolean | |||
| } | |||
|
|
|||
| // TODO: Remove this eslint rule once https://github.com/babel/babel-eslint/pull/584 | |||
| // is merged in. | |||
| /* eslint-disable no-use-before-define */ | |||
There was a problem hiding this comment.
You should be able to remove this too since the PR above is merged
There was a problem hiding this comment.
I think we have an old version of flow since I still go the pre-commit lint error when I removed this
There was a problem hiding this comment.
Ok we should change the TODO then to be updating eslint rather than waiting for the PR to be merged. I think the TODO is still relevant as long as the error is thrown
| @@ -575,9 +572,6 @@ export type Label = { | |||
| projectId: string, | |||
| user?: string | |||
| } | |||
|
|
|||
| // TODO: Remove this eslint rule once https://github.com/babel/babel-eslint/pull/584 | |||
| // is merged in. | |||
| /* eslint-enable no-use-before-define */ | |||
miles-grant-ibigroup
requested changes
Nov 9, 2023
|
woah happy 1000 |
miles-grant-ibigroup
approved these changes
Nov 9, 2023
|
Happy 1000 everyone. Time to merge the documentation now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
I'm not sure how I originally found this. I'm also not sure if this has impact but it's probably best to remove?