Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add genesis state root test #33

Closed

Conversation

dragan2234
Copy link
Contributor

Adding genesis state root test, ported from go test case: https://github.com/Quadratic-Labs/VerkleTries_Besu/blob/feature/test-genesis/tests/root-hashes/golang/main.go#L136

PR description

Fixed Issue(s)

Copy link

  • I thought about the changelog.

Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, maybe we could move the set of key values to an separate file just to keep the test class clean

dragan2234 and others added 3 commits January 25, 2024 20:07
Signed-off-by: Dragan Pilipovic <[email protected]>
Signed-off-by: Thomas Zamojski <[email protected]>
Signed-off-by: Dragan Pilipovic <[email protected]>
Signed-off-by: Dragan Pilipovic <[email protected]>
@dragan2234 dragan2234 force-pushed the feat/add-genesis-state-root-test branch from 1a1cfdf to 46f0943 Compare January 25, 2024 19:08
Signed-off-by: Dragan Pilipovic <[email protected]>
@dragan2234 dragan2234 force-pushed the feat/add-genesis-state-root-test branch from 4b3a497 to 9d5f7ab Compare January 25, 2024 19:10
Signed-off-by: Dragan Pilipovic <[email protected]>
@dragan2234
Copy link
Contributor Author

@gfukushima added that too now. There was an issue with genesis csv file on this PR: #25 I have cherry picked commit and fixed it

@dragan2234
Copy link
Contributor Author

Closing this one since it is included in #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants