-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add genesis state root test #33
Closed
dragan2234
wants to merge
5
commits into
hyperledger:main
from
dragan2234:feat/add-genesis-state-root-test
Closed
add genesis state root test #33
dragan2234
wants to merge
5
commits into
hyperledger:main
from
dragan2234:feat/add-genesis-state-root-test
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed
gfukushima
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, maybe we could move the set of key values to an separate file just to keep the test class clean
Signed-off-by: Dragan Pilipovic <[email protected]>
Signed-off-by: Thomas Zamojski <[email protected]> Signed-off-by: Dragan Pilipovic <[email protected]>
Signed-off-by: Dragan Pilipovic <[email protected]>
dragan2234
force-pushed
the
feat/add-genesis-state-root-test
branch
from
January 25, 2024 19:08
1a1cfdf
to
46f0943
Compare
Signed-off-by: Dragan Pilipovic <[email protected]>
dragan2234
force-pushed
the
feat/add-genesis-state-root-test
branch
from
January 25, 2024 19:10
4b3a497
to
9d5f7ab
Compare
Signed-off-by: Dragan Pilipovic <[email protected]>
@gfukushima added that too now. There was an issue with genesis csv file on this PR: #25 I have cherry picked commit and fixed it |
Closing this one since it is included in #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding genesis state root test, ported from go test case: https://github.com/Quadratic-Labs/VerkleTries_Besu/blob/feature/test-genesis/tests/root-hashes/golang/main.go#L136
PR description
Fixed Issue(s)