-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft of stationary extreme value analysis module #175
Draft
Sci-pio
wants to merge
112
commits into
main
Choose a base branch
from
extremes-wrapper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solution for multiple dispatch of julia function, and started implementing conversions for Extremes.jl data structures
…ameter estimation
…ns to multiple dispatch architecture of gevfit()
…ed 'structures' subpackage structure
…rdance with rest of extreme_value_analysis package
…ilar API to the one in xclim
…f Extremes.params()
…big because of folder name change
…conflict with xhydro
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Welcome, new contributor! It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the
Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨ |
…ing. Good luck everyone!
…meters in a single operation (for now, works gevfit)
…ithub.com/hydrologie/xhydro into nonstationary_extreme_value_analysis_copy
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
A new subpackage called extreme_value_analysis has been added. This subpackage is a python wrapper around the julia Extremes.jl package.
As I am leaving, all the information about what needs to be done to finish this project can be found on 'https://docs.google.com/document/d/1Jg5_xQoyyekLfg8sfDff5-XGAzomPE8hSmA_VJZAKMo/edit?usp=sharing' (in French).
@ospinajulian will be taking care of the julia wrapper from now on!
Does this PR introduce a breaking change?
Not to my knowledge.
Other information:
Need to add juliacall to the testing environment on GitHub for tests to pass.