Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gazebo namespace #93

Merged
merged 82 commits into from
Jan 15, 2024
Merged

Conversation

delihus
Copy link
Contributor

@delihus delihus commented Jan 9, 2024

Added multiplerobot simulation with namespaced robots in Gazebo Ignition.

Added tests in Ignition for the camera and the range sensors.
bump::minor

Dependencies:
husarion/ros_components_description#39
husarion/husarion_controllers#4
delihus/ros2_controllers#1
husarion/husarion_gz_worlds#5

Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
@delihus delihus changed the title Add gazebo namespace skipping industrial Add gazebo namespace Jan 10, 2024
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
@delihus delihus marked this pull request as ready for review January 11, 2024 08:47
Copy link
Contributor

@rafal-gorecki rafal-gorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all for now. Will review the tests soon.

.github/workflows/industrial_ci.yaml Outdated Show resolved Hide resolved
.github/workflows/industrial_ci.yaml Outdated Show resolved Hide resolved
rosbot_description/urdf/rosbot.urdf.xacro Show resolved Hide resolved
<xacro:unless value="${namespace == 'None'}">
<namespace>${namespace}</namespace>
</xacro:unless>
<namespace>${gz_control_namespace}</namespace>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a way to do not create new property?

Copy link
Contributor Author

@delihus delihus Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there is namespace_ext it throws:

[ros2-19] [ruby $(which ign) gazebo-1] terminate called after throwing an instance of 'rclcpp::exceptions::InvalidNamespaceError'
[ros2-19] [ruby $(which ign) gazebo-1]   what():  Invalid namespace: namespace must not end with a '/', unless only a '/':
[ros2-19] [ruby $(which ign) gazebo-1]   '/robot3/'

When there is namespace it gives None as namespace.

So the first approach is:

<xacro:unless value="${namespace == 'None'}">
  <namespace>${namespace}</namespace>
</xacro:unless>`

and the second with gz_control_namespace used the if condition on the begin of the file.

rosbot_gazebo/launch/multirobot_simulation.launch.py Outdated Show resolved Hide resolved
rafal-gorecki

This comment was marked as outdated.

@rafal-gorecki rafal-gorecki force-pushed the add-gazebo-namespace-skipping-industrial branch from fda9562 to 47700e6 Compare January 11, 2024 16:39
@rafal-gorecki rafal-gorecki self-requested a review January 11, 2024 18:02
Copy link
Contributor

@rafal-gorecki rafal-gorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@delihus delihus merged commit 65154a9 into humble Jan 15, 2024
3 checks passed
@delihus delihus deleted the add-gazebo-namespace-skipping-industrial branch January 15, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants