-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gazebo namespace #93
Conversation
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
…ken imu Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
This reverts commit 50c90e5.
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's all for now. Will review the tests soon.
<xacro:unless value="${namespace == 'None'}"> | ||
<namespace>${namespace}</namespace> | ||
</xacro:unless> | ||
<namespace>${gz_control_namespace}</namespace> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a way to do not create new property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When there is namespace_ext
it throws:
[ros2-19] [ruby $(which ign) gazebo-1] terminate called after throwing an instance of 'rclcpp::exceptions::InvalidNamespaceError'
[ros2-19] [ruby $(which ign) gazebo-1] what(): Invalid namespace: namespace must not end with a '/', unless only a '/':
[ros2-19] [ruby $(which ign) gazebo-1] '/robot3/'
When there is namespace
it gives None
as namespace.
So the first approach is:
<xacro:unless value="${namespace == 'None'}">
<namespace>${namespace}</namespace>
</xacro:unless>`
and the second with gz_control_namespace
used the if condition on the begin of the file.
Co-authored-by: rafal-gorecki <[email protected]>
Co-authored-by: rafal-gorecki <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
…dustrial' into add-gazebo-namespace-skipping-industrial
Signed-off-by: Jakub Delicat <[email protected]>
fda9562
to
47700e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok
Added multiplerobot simulation with namespaced robots in Gazebo Ignition.
Added tests in Ignition for the camera and the range sensors.
bump::minor
Dependencies:
husarion/ros_components_description#39
husarion/husarion_controllers#4
delihus/ros2_controllers#1
husarion/husarion_gz_worlds#5