Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix translation string in motioneye #128403

Closed
wants to merge 4 commits into from
Closed

Fix translation string in motioneye #128403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9049495
Fix translation string in motioneye
j4n-e4t Oct 14, 2024
0671f14
Remove ignore_translations from motioneye config_flow test
j4n-e4t Oct 15, 2024
2f9178d
Update homeassistant/components/motioneye/strings.json
j4n-e4t Oct 15, 2024
5cf4783
Merge branch 'home-assistant:dev' into j4n-e4t/translations-motioneye
j4n-e4t Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions homeassistant/components/motioneye/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
},
"abort": {
"already_configured": "[%key:common::config_flow::abort::already_configured_service%]",
"already_in_progress": "[%key:common::config_flow::abort::already_in_progress%]",
"reauth_successful": "[%key:common::config_flow::abort::reauth_successful%]"
}
},
Expand Down
5 changes: 0 additions & 5 deletions tests/components/motioneye/test_config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
MotionEyeClientInvalidAuthError,
MotionEyeClientRequestError,
)
import pytest

from homeassistant import config_entries
from homeassistant.components.hassio import HassioServiceInfo
Expand Down Expand Up @@ -391,10 +390,6 @@ async def test_hassio_ignored(hass: HomeAssistant) -> None:
assert result.get("reason") == "already_configured"


@pytest.mark.parametrize( # Remove when translations fixed
"ignore_translations",
["component.motioneye.config.abort.already_in_progress"],
)
async def test_hassio_abort_if_already_in_progress(hass: HomeAssistant) -> None:
"""Test Supervisor discovered flow aborts if user flow in progress."""
result = await hass.config_entries.flow.async_init(
Expand Down