-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added polling logic to ensure the retrieval of fully mature records from MN #3368
Conversation
…actResultsLogsWithRetry() Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Quality Gate passedIssues Measures |
Test Results 20 files - 7 267 suites - 109 46m 30s ⏱️ - 52m 18s For more details on these failures, see this check. Results for commit 256a28b. ± Comparison against base commit 16939ff. This pull request removes 6 and adds 3 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
…rds from MN (#3368) * fix: added polling logic to getContractResultWithRetry() and getContractResultsLogsWithRetry() Signed-off-by: Logan Nguyen <[email protected]> * fix: strictly throw errors if immature records found Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Logan Nguyen <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3368 +/- ##
==========================================
+ Coverage 84.79% 85.00% +0.21%
==========================================
Files 69 69
Lines 4721 4742 +21
Branches 1063 1067 +4
==========================================
+ Hits 4003 4031 +28
+ Misses 400 396 -4
+ Partials 318 315 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…eval of fully mature records from MN (#3370) fix: added polling logic to ensure the retrieval of fully mature records from MN (#3368) * fix: added polling logic to getContractResultWithRetry() and getContractResultsLogsWithRetry() * fix: strictly throw errors if immature records found --------- Signed-off-by: Logan Nguyen <[email protected]>
Description:
This PR enhances the retry mechanisms in getContractResultWithRetry() and getContractResultsLogsWithRetry() by adding polling logic to ensure the retrieval of fully mature records. Additionally, the Relay now implements strict error handling to throw exceptions when immature records are encountered. This approach aims to prevent the
Cannot read properties of null (reading 'xyz')
error caused by improper handling of null checks.Related issue(s):
Fixes #3366
Notes for reviewer:
Checklist