Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry pick #3368 fix: added polling logic to ensure the retrieval of fully mature records from MN #3370

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

quiet-node
Copy link
Member

Description:
This PR cherry-picks #3368 fix: added polling logic to ensure the retrieval of fully mature records from MN into release/0.63

Related issue(s):

Fixes #3366

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…rds from MN (#3368)

* fix: added polling logic to getContractResultWithRetry() and getContractResultsLogsWithRetry()

Signed-off-by: Logan Nguyen <[email protected]>

* fix: strictly throw errors if immature records found

Signed-off-by: Logan Nguyen <[email protected]>

---------

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node quiet-node added the process Build, test and deployment-process related tasks label Jan 10, 2025
@quiet-node quiet-node added this to the 0.63.1 milestone Jan 10, 2025
@quiet-node quiet-node self-assigned this Jan 10, 2025
@quiet-node quiet-node requested review from a team as code owners January 10, 2025 17:34
Copy link

github-actions bot commented Jan 10, 2025

Test Results

 21 files  +  5  269 suites  +19   33m 44s ⏱️ - 16m 42s
615 tests +317  605 ✅ +319  4 💤 +1  6 ❌  - 3 
718 runs  +117  708 ✅ +130  4 💤  - 4  6 ❌  - 9 

For more details on these failures, see this check.

Results for commit e5cf13a. ± Comparison against base commit 593a47f.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node merged commit e80299b into release/0.63 Jan 10, 2025
48 of 50 checks passed
@quiet-node quiet-node deleted the cherry-pick-#3368 branch January 10, 2025 18:30
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (593a47f) to head (e5cf13a).
Report is 1 commits behind head on release/0.63.

Files with missing lines Patch % Lines
packages/relay/src/lib/clients/mirrorNodeClient.ts 82.85% 3 Missing and 3 partials ⚠️
packages/relay/src/lib/eth.ts 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/0.63    #3370      +/-   ##
================================================
+ Coverage         83.18%   84.87%   +1.69%     
================================================
  Files                69       69              
  Lines              4721     4742      +21     
  Branches           1063     1067       +4     
================================================
+ Hits               3927     4025      +98     
+ Misses              445      400      -45     
+ Partials            349      317      -32     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 79.56% <82.22%> (+0.06%) ⬆️
server 83.28% <ø> (ø)
ws-server 36.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../lib/services/ethService/ethCommonService/index.ts 90.20% <100.00%> (+1.47%) ⬆️
packages/relay/src/lib/eth.ts 86.01% <75.00%> (+5.56%) ⬆️
packages/relay/src/lib/clients/mirrorNodeClient.ts 89.16% <82.85%> (+0.54%) ⬆️

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants