feat: Added ability to load spending plans from environment variable.…

[ebadiere]

Cherry-pick. Added the ability to load spending plans from environment variable.

Issue: #3153

… (#3153)

• feat: Added ability to load spening plans from environment variable.

• feat: Now uses one property for either spending plan file or JSON content.

fix: removed .only

fix: Cleaned up file and env var evaluation.

fix: Flaky unit test fix.

feat: Refactored implementation and updated tests.

• fix: Adding updated package-lock.json

• fix: Updated global variable reference to the new HBAR_SPENDING_PLANS_CONFIG

fix: Test fix.

fix: Removed irrelevant test since we now use either env var or file for spending plan.

fix: Updated HBAR_SPENDING_PLANS_CONFIG from HBAR_SPENDING_PLANS_CONFIG_FILE

• fix: Clean up. Updated logging and appropriate tests.

• fix: Replaced the useInMemoryRedisServer with the start and stop redis in the before and after mocha functions.

• fix: Test fix. Added the envName back to the loggerService test.

• Update docs/configuration.md

• fix: Added back file not found tests.

• fix: Updated file name in withOverriddenEnvsInMochaTest with existing file.

• fix: Clear the spending plan repository in a test as in CI it seems to already be populated.

fix: Cleanup.

• fix: Added more time for the HBar Rate Limiter to update expenses in the background.

• chore: divided hbar limtier tests into different batches

• fix: Removed the clearing of the spending plans.

• chore: divided hbar limtier tests into different batches (chore: divided hbar limtier tests into different batches #3181)

• chore: divided hbar limtier tests into different batches

• fix: fixed acceptance.yml

---

• Update packages/relay/src/lib/config/hbarSpendingPlanConfigService.ts

• fix: Restored class comments and corrected HBAR_SPENDING_PLAN_CONFIG.

• test: fix hbarSpendingPlanConfigService.spec.ts

• test: remove .only from describe

• test: disconnect redis client after tests with shared cache

---

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Test Results

 20 files   -   3  256 suites   - 46   34m 4s ⏱️ +43s
604 tests +  3  597 ✅ +  9  4 💤 +1  3 ❌  - 7 
641 runs   - 198  634 ✅  - 192  4 💤 +1  3 ❌  - 7 

For more details on these failures, see this check.

Results for commit d110979. ± Comparison against base commit 1af16a2.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.76%. Comparing base (1af16a2) to head (d110979).
Report is 1 commits behind head on release/0.59.

Files with missing lines	Patch %	Lines
...ay/src/lib/config/hbarSpendingPlanConfigService.ts	84.61%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release/0.59    #3201      +/-   ##
================================================
- Coverage         83.39%   82.76%   -0.64%     
================================================
  Files                66       69       +3     
  Lines              4283     4451     +168     
  Branches            835      875      +40     
================================================
+ Hits               3572     3684     +112     
- Misses              471      515      +44     
- Partials            240      252      +12     

Flag	Coverage Δ
config-service	98.14% <ø> (ø)
relay	85.54% <85.71%> (-0.06%)	⬇️
server	83.52% <ø> (ø)
ws-server	36.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ckages/config-service/src/services/globalConfig.ts	100.00% <ø> (ø)
...kages/relay/src/lib/clients/cache/localLRUCache.ts	98.46% <100.00%> (+4.71%)	⬆️
...ay/src/lib/config/hbarSpendingPlanConfigService.ts	95.49% <84.61%> (-2.60%)	⬇️

... and 12 files with indirect coverage changes