-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 3152 spendingplan as env var acceptance test fix #3184
Conversation
Signed-off-by: ebadiere <[email protected]>
…tent. Signed-off-by: ebadiere <[email protected]> fix: removed .only Signed-off-by: ebadiere <[email protected]> fix: Cleaned up file and env var evaluation. Signed-off-by: ebadiere <[email protected]> fix: Flaky unit test fix. Signed-off-by: ebadiere <[email protected]> feat: Refactored implementation and updated tests. Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
…_CONFIG Signed-off-by: ebadiere <[email protected]> fix: Test fix. Signed-off-by: ebadiere <[email protected]> fix: Removed irrelevant test since we now use either env var or file for spending plan. Signed-off-by: ebadiere <[email protected]> fix: Updated HBAR_SPENDING_PLANS_CONFIG from HBAR_SPENDING_PLANS_CONFIG_FILE Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
…s in the before and after mocha functions. Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Co-authored-by: Victor Yanev <[email protected]> Signed-off-by: Eric Badiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
…ng file. Signed-off-by: ebadiere <[email protected]>
…o already be populated. Signed-off-by: ebadiere <[email protected]> fix: Cleanup. Signed-off-by: ebadiere <[email protected]>
…the background. Signed-off-by: ebadiere <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
…erent-batches' into 3152-spendingplan-as-env-var Signed-off-by: ebadiere <[email protected]>
Quality Gate passedIssues Measures |
Test Results 4 files - 14 418 suites +172 19s ⏱️ - 35m 10s Results for commit 011aca2. ± Comparison against base commit ff2c827. This pull request removes 604 and adds 1473 tests. Note that renamed tests count towards both.
This pull request removes 4 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
|
Covered by #3201 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3184 +/- ##
==========================================
- Coverage 83.39% 83.22% -0.18%
==========================================
Files 66 66
Lines 4283 4287 +4
Branches 835 836 +1
==========================================
- Hits 3572 3568 -4
- Misses 471 474 +3
- Partials 240 245 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR is a branch of PR#3153 with the HBar Rate Limiter fix in the acceptance tests. Using a new branch because there is odd behavior in github ATM.
Related issue(s):
Fixes #3152