-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adds eslint rules in eslintrc #3173
Conversation
…r running pre commit hook Signed-off-by: Konstantina Blazhukova <[email protected]>
Test Results 20 files ± 0 279 suites +18 36m 4s ⏱️ - 2m 39s For more details on these failures, see this check. Results for commit 3b0d0ac. ± Comparison against base commit c73d7cd. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: Konstantina Blazhukova <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! Thanks for doing this!
Q: So now will it automatically lint the whole codebase or do I still have to manually run the lint
command?
@quiet-node yes, currently its not automatic yet, i will do the eslint --fix in a separate pr together with the hook that will fix linting issues before each commit. Its better to do it this way in order to not flood this PR with changes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3173 +/- ##
==========================================
+ Coverage 82.58% 83.39% +0.81%
==========================================
Files 69 66 -3
Lines 4438 4283 -155
Branches 870 835 -35
==========================================
- Hits 3665 3572 -93
+ Misses 527 471 -56
+ Partials 246 240 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
* Adds linting rules and lint script to all the packages; foundation for running pre commit hook Signed-off-by: Konstantina Blazhukova <[email protected]> * Removes license header rule and uninstalls unecessary plugin Signed-off-by: Konstantina Blazhukova <[email protected]> --------- Signed-off-by: Konstantina Blazhukova <[email protected]>
Description:
This PR adds relevant rules to the .eslintrc.js file, adds lint script to package.json in different packages and adds eslint to husky hook
This is much needed to ensure good practices are followed, as well as styling and formatting of the code
Related issue(s):
Fixes #3064