Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint to be run pre-commit #3064

Closed
konstantinabl opened this issue Oct 4, 2024 · 0 comments · Fixed by #3173
Closed

Add eslint to be run pre-commit #3064

konstantinabl opened this issue Oct 4, 2024 · 0 comments · Fixed by #3173
Assignees
Labels
Internal For changes that affect the project's internal workings but not its outward-facing functionality.
Milestone

Comments

@konstantinabl
Copy link
Collaborator

Problem

Currently, we have eslint but it is not actually used when committing and thus not enforcing any useful rules like for example sort-imports, which leads to different PRs rearranging imports and flooding PRs with unneeded changes. On top of this, eslint offers many other benefits that ensure code quality and consistency.

Solution

Add eslint to the husky pre-commit script

Alternatives

No response

@konstantinabl konstantinabl added the enhancement New feature or request label Oct 4, 2024
@konstantinabl konstantinabl self-assigned this Oct 4, 2024
@konstantinabl konstantinabl linked a pull request Oct 29, 2024 that will close this issue
@quiet-node quiet-node added this to the 0.60.0 milestone Oct 30, 2024
@quiet-node quiet-node added Internal For changes that affect the project's internal workings but not its outward-facing functionality. and removed enhancement New feature or request labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants