-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Refactor count/countna to use FExpr #3440
Merged
Merged
Changes from 1 commit
Commits
Show all changes
126 commits
Select commit
Hold shift + click to select a range
6b1c960
changes to allow more flexibility for reduction operations
samukweku b79dc27
add countna with additional tests
samukweku 4222481
update countna doc link
samukweku 8cd4106
add count fexpr
samukweku 1be2f5c
add count for all rows
samukweku 4ca61ac
simplify logic choice
samukweku 518b12d
update docs links
samukweku c8311f3
update code based on feedback
samukweku fd5311a
cleanup
samukweku 29f5145
updates based on feedback
samukweku fd878f9
2022 -> 2023 copyright
samukweku cb94aa9
Remove irrelevant header file
samukweku a37e3e1
code update with more shortcuts
samukweku d547533
remove irrelevant header files
samukweku c693927
code update based on feedback
samukweku 3d0f9d4
add more details for count in docs
samukweku 8270fa2
countna must have an iterable
samukweku f52a618
add test for void countna
samukweku 18de8cf
update based on feedback
samukweku 83d7e89
defensive steps for empty value
samukweku 5120177
update based on feedback
samukweku 334c698
Update src/core/expr/fexpr_count_countna.cc
samukweku 5f341fa
Update src/core/column/countna.h
samukweku cba8204
Update src/core/column/countna.h
samukweku 11ced22
Update src/core/column/countna.h
samukweku 0a2f5be
Update docs/api/dt/count.rst
samukweku 8077bba
Update docs/api/dt/count.rst
samukweku b1c7f98
more descriptive template variables
samukweku 175ed00
single template type for min/max/sum/prod
samukweku 6131f69
count all rows use unary impl
samukweku ba50e3e
create dummy column for count
samukweku 3cc0ddf
remove whitespace
samukweku 171289b
add countna when cols is None
samukweku a6ad80c
add more details for count and countna
samukweku 8394ef1
update countna
samukweku 9b297dc
fix countna docs link
samukweku 3f958c9
update counta logic for Frame vs FExpr
samukweku 316a71b
Update src/core/expr/fexpr_count_countna.cc
samukweku b2c4ea5
Update src/core/expr/fexpr_count_countna.cc
samukweku 0f9e60e
update count_all_rows to avoid dummy col creation
samukweku e7ad7c1
cast inplace for sumprod
samukweku 22fbcd7
restore cast in place for sumprod
samukweku 6a45afd
add explicit stype to reduce_unary.h
samukweku 254954e
rename template parameter for single type
samukweku 1788438
update code to use FExpr_ReduceUnary
samukweku c6f65d4
add example for countna when no col is passed
samukweku 120e02f
Update src/core/expr/fexpr_count_countna.cc
samukweku 14a7047
Update src/core/expr/fexpr_count_countna.cc
samukweku d3266a1
updates based on feedback
samukweku 2436af6
remove xfail for countna
samukweku 5207e67
cleanup
samukweku 88efc58
updates based on feedback
samukweku fcbdd79
no need to check for gby
samukweku ac39c5f
fix indent
samukweku 2c567f5
Update docs/api/dt/countna.rst
samukweku 52be77f
focus only on count
samukweku adf7143
return FExpr
samukweku 109c76f
Update countna.h
samukweku 7770899
Merge branch 'main' into samukweku/fexpr_count_countna
oleksiyskononenko 8b5ac15
changes to allow more flexibility for reduction operations
samukweku f4c65f0
add countna with additional tests
samukweku 2063dea
update countna doc link
samukweku e21e08a
add count fexpr
samukweku 633e3b1
add count for all rows
samukweku 6dea1a6
simplify logic choice
samukweku 2a4b4f8
update docs links
samukweku 4502322
update code based on feedback
samukweku fc4bd05
cleanup
samukweku 42a5cfd
updates based on feedback
samukweku b85f137
2022 -> 2023 copyright
samukweku a151dcb
Remove irrelevant header file
samukweku 33e5d01
code update with more shortcuts
samukweku 8200141
remove irrelevant header files
samukweku ce7e9cd
code update based on feedback
samukweku b33d8ef
add more details for count in docs
samukweku ccd27d4
countna must have an iterable
samukweku 6b01148
add test for void countna
samukweku 069a488
update based on feedback
samukweku 957fcdf
defensive steps for empty value
samukweku fafb095
update based on feedback
samukweku cea8e29
Update src/core/expr/fexpr_count_countna.cc
samukweku 657beb3
Update src/core/column/countna.h
samukweku b0a3595
Update src/core/column/countna.h
samukweku f357edd
Update src/core/column/countna.h
samukweku cf15fbe
Update docs/api/dt/count.rst
samukweku 8fbeabf
Update docs/api/dt/count.rst
samukweku 729591b
more descriptive template variables
samukweku 6fa2664
single template type for min/max/sum/prod
samukweku ef9553a
count all rows use unary impl
samukweku ab846a4
create dummy column for count
samukweku 6499d23
remove whitespace
samukweku 7c3dce0
add countna when cols is None
samukweku 826fadf
add more details for count and countna
samukweku e6d188b
update countna
samukweku 82fdf49
fix countna docs link
samukweku 1555b5e
update counta logic for Frame vs FExpr
samukweku 20626b2
Update src/core/expr/fexpr_count_countna.cc
samukweku 56fef37
Update src/core/expr/fexpr_count_countna.cc
samukweku 3bca529
update count_all_rows to avoid dummy col creation
samukweku 7da25f2
cast inplace for sumprod
samukweku 2d579f2
restore cast in place for sumprod
samukweku 50d1fad
add explicit stype to reduce_unary.h
samukweku 9d29154
rename template parameter for single type
samukweku e872a44
update code to use FExpr_ReduceUnary
samukweku 514610f
add example for countna when no col is passed
samukweku b0c513a
Update src/core/expr/fexpr_count_countna.cc
samukweku f28e2de
Update src/core/expr/fexpr_count_countna.cc
samukweku bf71889
updates based on feedback
samukweku 74d5089
remove xfail for countna
samukweku d852148
cleanup
samukweku 6371cf5
updates based on feedback
samukweku aa076ac
no need to check for gby
samukweku a9a45dd
fix indent
samukweku f53f1c8
Update docs/api/dt/countna.rst
samukweku dfa017f
focus only on count
samukweku 4f5d071
return FExpr
samukweku 8397a8f
Update countna.h
samukweku d61ac2e
Various fixes
oleksiyskononenko 27480da
Merge
oleksiyskononenko 39ad7d4
Remove unused files
oleksiyskononenko 7b63805
Restore changes
oleksiyskononenko c1e75b6
Remove one more unused file
oleksiyskononenko eb77f2f
More fixes
oleksiyskononenko 2ce4880
Remove unnecessary newline
oleksiyskononenko 74bd5b2
Add some comment
oleksiyskononenko 6818c14
Fixes to docs
oleksiyskononenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this change was introduced, we don't need additional treatment of date32/time64 as internally there are the same as int32/int64.