Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Refactor count/countna to use FExpr #3440

Merged
merged 126 commits into from
Apr 22, 2023
Merged

[ENH] Refactor count/countna to use FExpr #3440

merged 126 commits into from
Apr 22, 2023

Commits on Apr 11, 2023

  1. changes to allow more flexibility for reduction operations

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    6b1c960 View commit details
    Browse the repository at this point in the history

  2. add countna with additional tests

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b79dc27 View commit details
    Browse the repository at this point in the history

  3. update countna doc link

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    4222481 View commit details
    Browse the repository at this point in the history

  4. add count fexpr

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8cd4106 View commit details
    Browse the repository at this point in the history

  5. add count for all rows

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    1be2f5c View commit details
    Browse the repository at this point in the history

  6. simplify logic choice

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    4ca61ac View commit details
    Browse the repository at this point in the history

  7. update docs links

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    518b12d View commit details
    Browse the repository at this point in the history

  8. update code based on feedback

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c8311f3 View commit details
    Browse the repository at this point in the history

  9. cleanup

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    fd5311a View commit details
    Browse the repository at this point in the history

  10. updates based on feedback

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    29f5145 View commit details
    Browse the repository at this point in the history

  11. 2022 -> 2023 copyright

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    fd878f9 View commit details
    Browse the repository at this point in the history

  12. Remove irrelevant header file

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    cb94aa9 View commit details
    Browse the repository at this point in the history

  13. code update with more shortcuts

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    a37e3e1 View commit details
    Browse the repository at this point in the history

  14. remove irrelevant header files

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d547533 View commit details
    Browse the repository at this point in the history

  15. code update based on feedback

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c693927 View commit details
    Browse the repository at this point in the history

  16. add more details for count in docs

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    3d0f9d4 View commit details
    Browse the repository at this point in the history

  17. countna must have an iterable

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8270fa2 View commit details
    Browse the repository at this point in the history

  18. add test for void countna

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    f52a618 View commit details
    Browse the repository at this point in the history

  19. update based on feedback

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    18de8cf View commit details
    Browse the repository at this point in the history

  20. defensive steps for empty value

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    83d7e89 View commit details
    Browse the repository at this point in the history

  21. update based on feedback

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5120177 View commit details
    Browse the repository at this point in the history

  22. Update src/core/expr/fexpr_count_countna.cc 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    334c698 View commit details
    Browse the repository at this point in the history

  23. Update src/core/column/countna.h 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5f341fa View commit details
    Browse the repository at this point in the history

  24. Update src/core/column/countna.h 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    cba8204 View commit details
    Browse the repository at this point in the history

  25. Update src/core/column/countna.h 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    11ced22 View commit details
    Browse the repository at this point in the history

  26. Update docs/api/dt/count.rst 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    0a2f5be View commit details
    Browse the repository at this point in the history

  27. Update docs/api/dt/count.rst 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8077bba View commit details
    Browse the repository at this point in the history

  28. more descriptive template variables

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b1c7f98 View commit details
    Browse the repository at this point in the history

  29. single template type for min/max/sum/prod

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    175ed00 View commit details
    Browse the repository at this point in the history

  30. count all rows use unary impl

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    6131f69 View commit details
    Browse the repository at this point in the history

  31. create dummy column for count

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ba50e3e View commit details
    Browse the repository at this point in the history

  32. remove whitespace

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    3cc0ddf View commit details
    Browse the repository at this point in the history

  33. add countna when cols is None

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    171289b View commit details
    Browse the repository at this point in the history

  34. add more details for count and countna

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    a6ad80c View commit details
    Browse the repository at this point in the history

  35. update countna

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    8394ef1 View commit details
    Browse the repository at this point in the history

  36. fix countna docs link

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    9b297dc View commit details
    Browse the repository at this point in the history

  37. update counta logic for Frame vs FExpr

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    3f958c9 View commit details
    Browse the repository at this point in the history

  38. Update src/core/expr/fexpr_count_countna.cc 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    316a71b View commit details
    Browse the repository at this point in the history

  39. Update src/core/expr/fexpr_count_countna.cc 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b2c4ea5 View commit details
    Browse the repository at this point in the history

  40. update count_all_rows to avoid dummy col creation

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    0f9e60e View commit details
    Browse the repository at this point in the history

  41. cast inplace for sumprod

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    e7ad7c1 View commit details
    Browse the repository at this point in the history

  42. restore cast in place for sumprod

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    22fbcd7 View commit details
    Browse the repository at this point in the history

  43. add explicit stype to reduce_unary.h

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    6a45afd View commit details
    Browse the repository at this point in the history

  44. rename template parameter for single type

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    254954e View commit details
    Browse the repository at this point in the history

  45. update code to use FExpr_ReduceUnary

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    1788438 View commit details
    Browse the repository at this point in the history

  46. add example for countna when no col is passed

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    c6f65d4 View commit details
    Browse the repository at this point in the history

  47. Update src/core/expr/fexpr_count_countna.cc 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    120e02f View commit details
    Browse the repository at this point in the history

  48. Update src/core/expr/fexpr_count_countna.cc 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    14a7047 View commit details
    Browse the repository at this point in the history

  49. updates based on feedback

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d3266a1 View commit details
    Browse the repository at this point in the history

  50. remove xfail for countna

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    2436af6 View commit details
    Browse the repository at this point in the history

  51. cleanup

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5207e67 View commit details
    Browse the repository at this point in the history

  52. updates based on feedback

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    88efc58 View commit details
    Browse the repository at this point in the history

  53. no need to check for gby

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    fcbdd79 View commit details
    Browse the repository at this point in the history

  54. fix indent

    @samukweku
    samukweku committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ac39c5f View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Update docs/api/dt/countna.rst 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko authored Apr 17, 2023
    Configuration menu
    Copy the full SHA
    2c567f5 View commit details
    Browse the repository at this point in the history

  2. focus only on count

    @samukweku
    samukweku committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    52be77f View commit details
    Browse the repository at this point in the history

  3. return FExpr

    @samukweku
    samukweku committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    adf7143 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Update countna.h

    @samukweku
    samukweku authored Apr 18, 2023
    Configuration menu
    Copy the full SHA
    109c76f View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Merge branch 'main' into samukweku/fexpr_count_countna

    @oleksiyskononenko
    oleksiyskononenko committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    7770899 View commit details
    Browse the repository at this point in the history

  2. changes to allow more flexibility for reduction operations

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    8b5ac15 View commit details
    Browse the repository at this point in the history

  3. add countna with additional tests

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    f4c65f0 View commit details
    Browse the repository at this point in the history

  4. update countna doc link

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    2063dea View commit details
    Browse the repository at this point in the history

  5. add count fexpr

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    e21e08a View commit details
    Browse the repository at this point in the history

  6. add count for all rows

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    633e3b1 View commit details
    Browse the repository at this point in the history

  7. simplify logic choice

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6dea1a6 View commit details
    Browse the repository at this point in the history

  8. update docs links

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    2a4b4f8 View commit details
    Browse the repository at this point in the history

  9. update code based on feedback

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    4502322 View commit details
    Browse the repository at this point in the history

  10. cleanup

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    fc4bd05 View commit details
    Browse the repository at this point in the history

  11. updates based on feedback

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    42a5cfd View commit details
    Browse the repository at this point in the history

  12. 2022 -> 2023 copyright

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    b85f137 View commit details
    Browse the repository at this point in the history

  13. Remove irrelevant header file

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    a151dcb View commit details
    Browse the repository at this point in the history

  14. code update with more shortcuts

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    33e5d01 View commit details
    Browse the repository at this point in the history

  15. remove irrelevant header files

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    8200141 View commit details
    Browse the repository at this point in the history

  16. code update based on feedback

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ce7e9cd View commit details
    Browse the repository at this point in the history

  17. add more details for count in docs

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    b33d8ef View commit details
    Browse the repository at this point in the history

  18. countna must have an iterable

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ccd27d4 View commit details
    Browse the repository at this point in the history

  19. add test for void countna

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6b01148 View commit details
    Browse the repository at this point in the history

  20. update based on feedback

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    069a488 View commit details
    Browse the repository at this point in the history

  21. defensive steps for empty value

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    957fcdf View commit details
    Browse the repository at this point in the history

  22. update based on feedback

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    fafb095 View commit details
    Browse the repository at this point in the history

  23. Update src/core/expr/fexpr_count_countna.cc 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    cea8e29 View commit details
    Browse the repository at this point in the history

  24. Update src/core/column/countna.h 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    657beb3 View commit details
    Browse the repository at this point in the history

  25. Update src/core/column/countna.h 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    b0a3595 View commit details
    Browse the repository at this point in the history

  26. Update src/core/column/countna.h 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    f357edd View commit details
    Browse the repository at this point in the history

  27. Update docs/api/dt/count.rst 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    cf15fbe View commit details
    Browse the repository at this point in the history

  28. Update docs/api/dt/count.rst 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    8fbeabf View commit details
    Browse the repository at this point in the history

  29. more descriptive template variables

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    729591b View commit details
    Browse the repository at this point in the history

  30. single template type for min/max/sum/prod

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6fa2664 View commit details
    Browse the repository at this point in the history

  31. count all rows use unary impl

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ef9553a View commit details
    Browse the repository at this point in the history

  32. create dummy column for count

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    ab846a4 View commit details
    Browse the repository at this point in the history

  33. remove whitespace

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6499d23 View commit details
    Browse the repository at this point in the history

  34. add countna when cols is None

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    7c3dce0 View commit details
    Browse the repository at this point in the history

  35. add more details for count and countna

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    826fadf View commit details
    Browse the repository at this point in the history

  36. update countna

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    e6d188b View commit details
    Browse the repository at this point in the history

  37. fix countna docs link

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    82fdf49 View commit details
    Browse the repository at this point in the history

  38. update counta logic for Frame vs FExpr

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    1555b5e View commit details
    Browse the repository at this point in the history

  39. Update src/core/expr/fexpr_count_countna.cc 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    20626b2 View commit details
    Browse the repository at this point in the history

  40. Update src/core/expr/fexpr_count_countna.cc 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    56fef37 View commit details
    Browse the repository at this point in the history

  41. update count_all_rows to avoid dummy col creation

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    3bca529 View commit details
    Browse the repository at this point in the history

  42. cast inplace for sumprod

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    7da25f2 View commit details
    Browse the repository at this point in the history

  43. restore cast in place for sumprod

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    2d579f2 View commit details
    Browse the repository at this point in the history

  44. add explicit stype to reduce_unary.h

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    50d1fad View commit details
    Browse the repository at this point in the history

  45. rename template parameter for single type

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    9d29154 View commit details
    Browse the repository at this point in the history

  46. update code to use FExpr_ReduceUnary

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    e872a44 View commit details
    Browse the repository at this point in the history

  47. add example for countna when no col is passed

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    514610f View commit details
    Browse the repository at this point in the history

  48. Update src/core/expr/fexpr_count_countna.cc 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    b0c513a View commit details
    Browse the repository at this point in the history

  49. Update src/core/expr/fexpr_count_countna.cc 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    f28e2de View commit details
    Browse the repository at this point in the history

  50. updates based on feedback

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    bf71889 View commit details
    Browse the repository at this point in the history

  51. remove xfail for countna

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    74d5089 View commit details
    Browse the repository at this point in the history

  52. cleanup

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    d852148 View commit details
    Browse the repository at this point in the history

  53. updates based on feedback

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6371cf5 View commit details
    Browse the repository at this point in the history

  54. no need to check for gby

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    aa076ac View commit details
    Browse the repository at this point in the history

  55. fix indent

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    a9a45dd View commit details
    Browse the repository at this point in the history

  56. Update docs/api/dt/countna.rst 

    Co-authored-by: Oleksiy <[email protected]>
    @samukweku @oleksiyskononenko
    samukweku and oleksiyskononenko committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    f53f1c8 View commit details
    Browse the repository at this point in the history

  57. focus only on count

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    dfa017f View commit details
    Browse the repository at this point in the history

  58. return FExpr

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    4f5d071 View commit details
    Browse the repository at this point in the history

  59. Update countna.h

    @samukweku
    samukweku committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    8397a8f View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Various fixes

    @oleksiyskononenko
    oleksiyskononenko committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    d61ac2e View commit details
    Browse the repository at this point in the history

  2. Merge

    @oleksiyskononenko
    oleksiyskononenko committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    27480da View commit details
    Browse the repository at this point in the history

  3. Remove unused files

    @oleksiyskononenko
    oleksiyskononenko committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    39ad7d4 View commit details
    Browse the repository at this point in the history

  4. Restore changes

    @oleksiyskononenko
    oleksiyskononenko committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    7b63805 View commit details
    Browse the repository at this point in the history

  5. Remove one more unused file

    @oleksiyskononenko
    oleksiyskononenko committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    c1e75b6 View commit details
    Browse the repository at this point in the history

  6. More fixes

    @oleksiyskononenko
    oleksiyskononenko committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    eb77f2f View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary newline

    @oleksiyskononenko
    oleksiyskononenko committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    2ce4880 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. Add some comment

    @oleksiyskononenko
    oleksiyskononenko committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    74bd5b2 View commit details
    Browse the repository at this point in the history

  2. Fixes to docs

    @oleksiyskononenko
    oleksiyskononenko committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    6818c14 View commit details
    Browse the repository at this point in the history