Sample App Works #55
Merged
Sample App Works #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitmold
force-pushed
the
sample_updates
branch
from
526ca1c to
6518697
Compare
|
Looks good to me, I say merge it! Nice initiative too! I really appreciate seeing things like this being maintained. |
|
For sure, I think it would be worthwhile to have a more developed sample app and move it out of this repository. That way it could have documentation about how to make something with the libraries here and people who are just interested in that can see a very simple codebase. I ended up wanting to run the sample because I've been trying to toy around with a version of tor-android that uses arti instead of c tor |
|
yeah, a well developed example would be good to have. In one sense, the Tor
Services app is a version of that.
I also think it still makes sense to keep this example here and keep it as
simple as possible. It is the "getting started" example.
|
|
Turns out that this broke the build in CI: |
eighthave
added a commit
to eighthave/tor-android
that referenced
this pull request
Dec 3, 2021
"NDK Side-by-side" packages are installed into $ANDROID_SDK_ROOT/ndk/ without the trailing "s": Android's sdkmanager was warning: Warning: Observed package id 'ndk;21.3.6528147' in inconsistent location '/opt/android-sdk/ndks/21.3.6528147' (Expected '/opt/android-sdk/ndk/21.3.6528147') closes guardianproject#55
|
I wrote a comment explaining what's going on here in #58 |
eighthave
added a commit
to eighthave/tor-android
that referenced
this pull request
Dec 9, 2021
"NDK Side-by-side" packages are installed into $ANDROID_SDK_ROOT/ndk/ without the trailing "s": Android's sdkmanager was warning: Warning: Observed package id 'ndk;21.3.6528147' in inconsistent location '/opt/android-sdk/ndks/21.3.6528147' (Expected '/opt/android-sdk/ndk/21.3.6528147') closes guardianproject#55
eighthave
added a commit
to eighthave/tor-android
that referenced
this pull request
Dec 9, 2021
This stays with OpenJDK 8 for now. closes guardianproject#55
syphyr
pushed a commit
to syphyr/tor-android
that referenced
this pull request
Dec 9, 2021
"NDK Side-by-side" packages are installed into $ANDROID_SDK_ROOT/ndk/ without the trailing "s": Android's sdkmanager was warning: Warning: Observed package id 'ndk;21.3.6528147' in inconsistent location '/opt/android-sdk/ndks/21.3.6528147' (Expected '/opt/android-sdk/ndk/21.3.6528147') closes guardianproject#55
syphyr
pushed a commit
to syphyr/tor-android
that referenced
this pull request
Dec 9, 2021
"NDK Side-by-side" packages are installed into $ANDROID_SDK_ROOT/ndk/ without the trailing "s": Android's sdkmanager was warning: Warning: Observed package id 'ndk;21.3.6528147' in inconsistent location '/opt/android-sdk/ndks/21.3.6528147' (Expected '/opt/android-sdk/ndk/21.3.6528147') closes guardianproject#55
syphyr
pushed a commit
to syphyr/tor-android
that referenced
this pull request
Dec 9, 2021
This stays with OpenJDK 8 for now. closes guardianproject#55
eighthave
added a commit
to eighthave/tor-android
that referenced
this pull request
Dec 16, 2021
"NDK Side-by-side" packages are installed into $ANDROID_SDK_ROOT/ndk/ without the trailing "s": Android's sdkmanager was warning: Warning: Observed package id 'ndk;21.3.6528147' in inconsistent location '/opt/android-sdk/ndks/21.3.6528147' (Expected '/opt/android-sdk/ndk/21.3.6528147') closes guardianproject#55
eighthave
added a commit
to eighthave/tor-android
that referenced
this pull request
Dec 16, 2021
This stays with OpenJDK 8 for now. closes guardianproject#55
eighthave
added a commit
to eighthave/tor-android
that referenced
this pull request
Dec 17, 2021
"NDK Side-by-side" packages are installed into $ANDROID_SDK_ROOT/ndk/ without the trailing "s": Android's sdkmanager was warning: Warning: Observed package id 'ndk;21.3.6528147' in inconsistent location '/opt/android-sdk/ndks/21.3.6528147' (Expected '/opt/android-sdk/ndk/21.3.6528147') closes guardianproject#55
eighthave
added a commit
to eighthave/tor-android
that referenced
this pull request
Dec 17, 2021
This stays with OpenJDK 8 for now. closes guardianproject#55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample app in this project has always been very barebones, but I noticed it wasn't kept up to date and wasn't working at all.
The first commit here gets the project to build on a fresh clone of this repository. The second gets the app running again, while updating libraries to latest tor-android, and generally updating the app's code to look like a more modern Android app.
This commit is the bare minimum to get it working again.