-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SampleApp fixes in #55 broke the CI #58
Comments
I tried configuring GitLab CI to show up on pull requests here, I'm not sure it worked. It might need to be set up using a token from a user who has admin access to this repo (I do not). Here's the process https://docs.gitlab.com/ee/user/project/integrations/github.html |
Might be fixed by #59 which is exporting the sample activity as required when targeting API 31. |
turns out to be unrelated to #55 but just happened at the same time, I have a fix |
Actually, there were two issues, I fixed the CI issue in #60 , but there is still one related to #55. And #59 didn't fix it, that run is here: https://gitlab.com/eighthave/tor-android/-/jobs/1846411910
|
This issue is occurring because when I updated the sample app I made it target the latest Android SDK (Android 12 API 31). My research shows that Android 12's I could fix this by making the sample app target API 30, but I think it would just be better to update the JDK that's running on the CI because @n8fr8 and us would just end up seeing this same issue occur whenever Orbot targets API 31. |
The |
I don't think I have a way to run ci builds on gitlab (seems that gitlab only mirrors the |
The Android team has really messed up this Java8 vs Java9+ stuff, it seems it is always just pain. First requiring Java8 only, then suddenly requiring Java9 or newer. For now, I'd prefer the quickest fix, which seems to be setting to SDK 30. I don't think it'll matter to the apps if this binary has a target SDK of 30, or at least not for a while. Please correct me if I'm wrong. The emulator setup in CI tends to be quite brittle, that's why I want to be conservative here. It seems like it works: If you make a fork on gitlab.com and just push your commits there, that used to work. But I guess they've added more restrictions to the free minutes. I guess the best solution would be to get GitLab CI running on GitHub. @n8fr8 would have to do that, or anyone with admin access to this project. Or someone could port it to GitHub Actions. I've never used that, but I suppose it could work. |
🤷♀️Hopefully this does it. |
@bitmold could you take a look at this? Turns out that #55 broke the build in CI:
The text was updated successfully, but these errors were encountered: